fix(UIHelper): wait for Quickstart Hide before dismiss - #136
Closed
gashcrumb wants to merge 2 commits into
Closed
Conversation
Immediate isVisible() raced login: the drawer often mounts afterward and its sticky progressbar then blocks waitForAppReady. Wait briefly for Hide instead; still no-op if Quickstart never appears. Co-authored-by: Cursor <cursoragent@cursor.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
Patch release for the dismissQuickstartIfVisible race fix; 2.1.4 is already published. Co-authored-by: Cursor <cursoragent@cursor.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
Member
Author
|
this isn't needed given the quickstart plugin was disabled by default in 2.1.4, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dismissQuickstartIfVisible()used an immediateisVisible()check, so it often no-op'd when the Quickstart drawer mounted shortly after login.waitForAppReady/waitForLoadthen timed out on the drawer's sticky[role="progressbar"](seen on overlays PR #2754).waitVisibleMs, default5000) before clicking; still return quietly if Quickstart never appears.waitForAppReadybefore dismiss — that wait includes the Quickstart progressbar.Test plan
ui-helper.tse2e-ocp-helmon a PR that callsdismissQuickstartIfVisible()after login (e.g. backstage workspace notifications / github-events)Made with Cursor