Rhidp 14314/attachment type model validation#3629
Conversation
|
This pull request adds a new top-level directory under |
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
PR Summary by QodoAdd model vision validation and block image attachments for non-vision models
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
27c2c65 to
2d859f5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3629 +/- ##
==========================================
- Coverage 57.34% 56.15% -1.20%
==========================================
Files 2381 2383 +2
Lines 95589 95592 +3
Branches 26720 26728 +8
==========================================
- Hits 54819 53679 -1140
+ Misses 40531 40233 -298
- Partials 239 1680 +1441
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
8a5871f to
a6b43f4
Compare
| }, | ||
| ); | ||
| const supportsVision = testResponse.ok; | ||
| ModelCapabilitiesCache.set(model, supportsVision); |
There was a problem hiding this comment.
Shouldn't we also include provider in the Key for cache.
a6b43f4 to
31ee1ba
Compare
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 10:55 PM UTC · Completed 11:12 PM UTC |
ReviewFindingsMedium
Low
Previous runReviewReason: stale-head The review agent reviewed commit Previous run (2)ReviewFindingsHigh
Medium
Low
Labels: PR introduces new API endpoint and modifies validation middleware with security-relevant findings (missing rate limiting, unbounded cache, middleware ordering). |
cd8e435 to
8d61302
Compare
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 10:03 PM UTC · Completed 10:17 PM UTC |
Add backend validation for image attachments, including a model vision capability check via /v1/validate-model-vision endpoint and middleware to reject attachments for non-vision models on /v1/query. RHIDP-14314 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
Signed-off-by: Lucas <lyoon@redhat.com>
|
🤖 Review · ❌ Terminated · Started 6:31 PM UTC · Ended 6:47 PM UTC |
|
🤖 Finished Review · ❌ Failure · Started 6:31 PM UTC · Completed 6:47 PM UTC |
|



Hey, I just made a Pull Request!
/v1/validate-model-visionendpoint that probes model visioncapability by sending a minimal test JPEG to LCS
/v1/responsesvalidateAttachmentsForModelmiddleware on/v1/queryto rejectimage attachments for non-vision models
ModelCapabilitiesCachesingleton to cache vision capabilityresults per model
console.logdebug statement from notebooks routerquery validation
https://redhat.atlassian.net/browse/RHIDP-14314
✔️ Checklist