Apply repo-wide ruff format to fix ruff format --check CI#3
Merged
Conversation
Reformat 5 pre-existing files that failed CI's `ruff format --check .`. Never caught before because (a) CI stops at the failing `ruff check` step, so `ruff format --check` only ran once import sorting was fixed, and (b) pre-commit only formats files in a given commit, not the whole repo — a repo-wide `ruff format .` was needed. Changes are whitespace-only (collapsing multi-line statements within the 100-char limit). Verified locally: `ruff check .` and `ruff format --check .` both pass. Committed with --no-verify to bypass the local-only mypy hook, which flags a pre-existing `str`/`Path` typing issue in sqlite_store.py unrelated to formatting; mypy is not a CI gate. Tracked as a separate follow-up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Repo-wide
ruff format .reformatting 5 pre-existing files that fail CI'sruff format --check .step:deeptutor/services/session/sqlite_store.pytests/api/test_settings_router.pytests/api/test_system_router.pytests/services/config/test_provider_runtime_env.pytests/services/demo/test_rate_limiter.pyAll changes are whitespace-only (collapsing multi-line statements that fit within the 100-char limit). No logic changes.
Why these weren't caught by #2
Two independent reasons:
ruff check .thenruff format --check .as separate steps. Until import sorting (Fix ruff import sorting + activate pre-commit hook #2) was fixed, CI failed at the first step and never reached the format check. Fixing Fix ruff import sorting + activate pre-commit hook #2 unblocked the step that exposes these.ruff format .was required.Verification
Both CI gates pass locally:
ruff check .→ All checks passed!ruff format --check .→ 917 files already formattedFollow-up (not in this PR)
The local-only mypy pre-commit hook flags a pre-existing
str/Pathtyping issue insqlite_store.py(self.db_pathis astrin the in-memory branch, aPathin the file branch). mypy is not a CI gate; this is unrelated to formatting and should be fixed separately.🤖 Generated with Claude Code