ci(maestro): bump WalletConnect/actions for redesigned /collect IC form#556
Conversation
…llect IC form Provisionally pinned to the branch tip of WalletConnect/actions#106 (KYC /collect inline IC form redesign). Re-pin to the merged-master SHA before merging, and only after buyer-experience #914 is deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @ignaciosantise's task in 1m 9s —— View job Review
✅ No issues found The diff bumps three pinned SHA refs ( The provisional-SHA situation (branch tip vs. merged-master) is correctly called out in inline comments on lines 433, 436, and 605 and is the central sequencing concern in the PR description. No additional flags from the breaking-changes or data-classification checks. |
Still provisional — re-pin to the merged-master SHA before merge. Advances
a6436df -> bb4ed70 so CI exercises the text-based consent ("0") and "Confirm"
selectors; the earlier testIDs were not exposed in the /collect WebView.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ct-ic-redesign # Conflicts: # .github/actions/walletkit-build-and-maestro/action.yml
The redesigned /collect IC form is taller than the viewport, but the webview clipped content two ways: scrollEnabled/nestedScrollEnabled were false, and the injected viewport CSS forced `overflow: hidden` on html/body. Together they made the consent checkbox + Confirm button unreachable (and Maestro scrolls no-op'd) on Android. Enable scrollEnabled/nestedScrollEnabled and switch the injected CSS to `overflow-x: hidden; overflow-y: auto` (keeping overscroll-behavior:none to avoid rubber-banding). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
WalletConnect/actions#106 merged to master (ddc7c0f) — the redesigned /collect inline IC flow fixes. Pin to the merged-master SHA and drop the provisional note. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the RN CLI wallet’s hosted /collect WebView + CI Maestro setup to align with the redesigned inline IC (/collect) flow, by enabling scrolling in the in-app WebView and pinning the shared WalletConnect/actions Maestro flows to the SHA that contains the updated text-driven interactions.
Changes:
- Enable vertical scrolling for the hosted
/collectWebView (CSS +react-native-webviewscrolling props). - Pin
WalletConnect/actions/maestro/*composite-action dependencies (pay-tests,setup,permit2-reset) toddc7c0f9….
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| wallets/rn_cli_wallet/src/modals/PaymentOptionsModal/CollectDataWebView.tsx | Allows the hosted /collect flow to scroll within the WebView (needed for the new inline consent + confirm interactions). |
| .github/actions/walletkit-build-and-maestro/action.yml | Pins the shared Maestro action refs to the updated SHA; adjusts the Permit2 reset step condition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if: ${{ !cancelled() && contains(inputs.maestro-tags, 'pay') && !contains(inputs.maestro-exclude-tags, 'pay-usdt-polygon') }} | ||
| # Pinned to the WalletConnect/actions#105 squash-merge SHA (4cec02a on master). | ||
| uses: WalletConnect/actions/maestro/permit2-reset@4cec02a4c535c254581471df287099a26d5eeffb | ||
| if: always() && contains(inputs.maestro-tags, 'pay') |
Bump
WalletConnect/actionsmaestro refs for the redesigned/collectIC formWalletConnect/buyer-experiencePR #914 redesigns the hosted KYC webview (the/collectroute the sample wallet opens in a WebView). The native Maestropayflows drive that webview by visible text, so they were updated in WalletConnect/actions#106 (submit is now "Confirm", the "Confirm your details" dialog is gone, and consent is an inline "I agree" checkbox). The verified KYC sequence is: scroll to "I agree" → tap it → scroll to "Confirm" → tap it.This PR pins every
WalletConnect/actions/maestro/*ref (pay-tests / setup / permit2-reset) to the merged-master SHA that contains those flow changes.ddc7c0f9acd8b1576e9a78f0ef67f4b8fbb36db2(squash-merge of fix(maestro/pay-tests): adapt KYC flows to redesigned /collect inline IC form WalletConnect/actions#106, nowmastertip).✅ Ready to merge — remaining requirement
/collectwebview loads (prod/staging) before thepay-tagged Maestro runs will pass — the flows now expect the redesigned form.Validation
Android Maestro
payruns were dispatched on this branch against the merged action and exercised the new KYC flow (scroll + tap "I agree", scroll + tap "Confirm").🤖 Generated with Claude Code