Skip to content

ci(maestro): bump WalletConnect/actions for redesigned /collect IC form#556

Merged
ignaciosantise merged 9 commits into
mainfrom
ci/bump-actions-collect-ic-redesign
Jul 3, 2026
Merged

ci(maestro): bump WalletConnect/actions for redesigned /collect IC form#556
ignaciosantise merged 9 commits into
mainfrom
ci/bump-actions-collect-ic-redesign

Conversation

@ignaciosantise

@ignaciosantise ignaciosantise commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Bump WalletConnect/actions maestro refs for the redesigned /collect IC form

WalletConnect/buyer-experience PR #914 redesigns the hosted KYC webview (the /collect route the sample wallet opens in a WebView). The native Maestro pay flows drive that webview by visible text, so they were updated in WalletConnect/actions#106 (submit is now "Confirm", the "Confirm your details" dialog is gone, and consent is an inline "I agree" checkbox). The verified KYC sequence is: scroll to "I agree" → tap it → scroll to "Confirm" → tap it.

This PR pins every WalletConnect/actions/maestro/* ref (pay-tests / setup / permit2-reset) to the merged-master SHA that contains those flow changes.

✅ Ready to merge — remaining requirement

Validation

Android Maestro pay runs were dispatched on this branch against the merged action and exercised the new KYC flow (scroll + tap "I agree", scroll + tap "Confirm").

🤖 Generated with Claude Code

…llect IC form

Provisionally pinned to the branch tip of WalletConnect/actions#106 (KYC
/collect inline IC form redesign). Re-pin to the merged-master SHA before
merging, and only after buyer-experience #914 is deployed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
deposit-app-demo Building Building Preview, Comment Jul 3, 2026 8:52pm
pos-demo Ready Ready Preview, Comment Jul 3, 2026 8:52pm

Request Review

@claude

claude Bot commented Jun 29, 2026

Copy link
Copy Markdown

Claude finished @ignaciosantise's task in 1m 9s —— View job


Review

  • Gather context
  • Read changed file
  • Run breaking changes subagent
  • Run data classification subagent
  • Post review findings

✅ No issues found

The diff bumps three pinned SHA refs (pay-tests, setup, permit2-reset) inside the composite action to a6436dfbb6404e7c086b24054821eb8efcc41b22. No inputs, outputs, or step IDs changed — consumer interface is intact.

The provisional-SHA situation (branch tip vs. merged-master) is correctly called out in inline comments on lines 433, 436, and 605 and is the central sequencing concern in the PR description. No additional flags from the breaking-changes or data-classification checks.

Still provisional — re-pin to the merged-master SHA before merge. Advances
a6436df -> bb4ed70 so CI exercises the text-based consent ("0") and "Confirm"
selectors; the earlier testIDs were not exposed in the /collect WebView.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ct-ic-redesign

# Conflicts:
#	.github/actions/walletkit-build-and-maestro/action.yml
…merged)

#106 now has master (#107 skip-metrics) merged in, so this single SHA carries
both the redesigned /collect flow fixes and the skip-metrics marker support.
Still provisional — re-pin to the merged-master SHA once #106 lands.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
#106 now taps the "I agree" consent label instead of the "0" value node,
which did not toggle consent in CI. Still provisional — re-pin to the
merged-master SHA once #106 lands.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
#106 now scrolls until the Confirm button is visible (off-screen on small
devices). Still provisional — re-pin to merged-master SHA once #106 lands.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
#106 now uses the verified KYC sequence (scroll+tap 'I agree', scroll+tap
'Confirm'). Still provisional — re-pin to merged-master SHA once #106 lands.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The redesigned /collect IC form is taller than the viewport, but the
webview clipped content two ways: scrollEnabled/nestedScrollEnabled were
false, and the injected viewport CSS forced `overflow: hidden` on
html/body. Together they made the consent checkbox + Confirm button
unreachable (and Maestro scrolls no-op'd) on Android.

Enable scrollEnabled/nestedScrollEnabled and switch the injected CSS to
`overflow-x: hidden; overflow-y: auto` (keeping overscroll-behavior:none
to avoid rubber-banding).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
WalletConnect/actions#106 merged to master (ddc7c0f) — the redesigned /collect
inline IC flow fixes. Pin to the merged-master SHA and drop the provisional note.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ignaciosantise ignaciosantise marked this pull request as ready for review July 3, 2026 20:52
Copilot AI review requested due to automatic review settings July 3, 2026 20:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the RN CLI wallet’s hosted /collect WebView + CI Maestro setup to align with the redesigned inline IC (/collect) flow, by enabling scrolling in the in-app WebView and pinning the shared WalletConnect/actions Maestro flows to the SHA that contains the updated text-driven interactions.

Changes:

  • Enable vertical scrolling for the hosted /collect WebView (CSS + react-native-webview scrolling props).
  • Pin WalletConnect/actions/maestro/* composite-action dependencies (pay-tests, setup, permit2-reset) to ddc7c0f9….

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
wallets/rn_cli_wallet/src/modals/PaymentOptionsModal/CollectDataWebView.tsx Allows the hosted /collect flow to scroll within the WebView (needed for the new inline consent + confirm interactions).
.github/actions/walletkit-build-and-maestro/action.yml Pins the shared Maestro action refs to the updated SHA; adjusts the Permit2 reset step condition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

if: ${{ !cancelled() && contains(inputs.maestro-tags, 'pay') && !contains(inputs.maestro-exclude-tags, 'pay-usdt-polygon') }}
# Pinned to the WalletConnect/actions#105 squash-merge SHA (4cec02a on master).
uses: WalletConnect/actions/maestro/permit2-reset@4cec02a4c535c254581471df287099a26d5eeffb
if: always() && contains(inputs.maestro-tags, 'pay')
@ignaciosantise ignaciosantise merged commit 9e67d09 into main Jul 3, 2026
15 of 16 checks passed
@ignaciosantise ignaciosantise deleted the ci/bump-actions-collect-ic-redesign branch July 3, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants