Fix leak of model_partitions catalog rows when deleting a partitioned model#9711
Merged
Conversation
In the model reconciler's deletion branch, models that had produced output returned immediately after dropping the output table, skipping clearPartitions. Since each model gets a fresh partitions model ID, the orphaned model_partitions rows could never be reclaimed, growing the catalog DB on create/delete churn. Now clearPartitions runs on every delete path after a successful output drop.
model_partitions\ catalog rows when deleting a partitioned modelmodel_partitions catalog rows when deleting a partitioned model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clearPartitions. The model's rows in themodel_partitionscatalog table were orphaned forever, since each model gets a freshPartitionsModelIdandclearPartitionsis the only caller ofDeleteModelPartitions.ModelReconciler.Reconcilenow falls through after a successful output drop, soclearPartitionsruns on every delete path.TestPartitionsClearedOnDelete) that fails on the old code (all partition rows orphaned) and passes with the fix.Steps to reproduce:
sqlite3 <project>/tmp/meta.db "SELECT COUNT(*) FROM model_partitions;"returns 50.Checklist: