fix: metrics SQL compiles IS FALSE / IS NOT FALSE identically to IS TRUE#9712
Merged
Conversation
parseIsTruthOperation ignored ast.IsTruthExpr.True, so IS FALSE compiled to the same expression as IS TRUE and IS NOT FALSE to the same as IS NOT TRUE, silently inverting boolean filters. Also compare against a typed boolean instead of the string 'TRUE', and include NULL rows in the negated forms (IS NOT TRUE / IS NOT FALSE) to match SQL semantics.
Collaborator
Author
|
@codex: review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseIsTruthOperationin the metrics SQL filter parser never inspectedast.IsTruthExpr.True, which distinguishesIS TRUEfromIS FALSE. As a result,flag IS FALSEcompiled to the exact same expression asflag IS TRUE(andIS NOT FALSEthe same asIS NOT TRUE), silently inverting boolean filters in metrics SQL queries, canvasdimension_filters, and SQL-based where expressions.node.TruesoIS FALSEcompiles toeq(expr, false)instead ofeq(expr, true).'TRUE', which relied on implicit string-to-boolean casts that are not reliable across ClickHouse/Druid.IS NOT TRUE/IS NOT FALSEnow compile toexpr != <bool> OR expr IS NULL, matching SQL semantics where the negated forms include NULL rows (a plain!=excludes them).Steps to reproduce manually:
mvthat has a boolean dimensionflag, run a metrics SQL query (e.g. via ametrics_sqlresolver in a custom API, or a canvas widget'sdimension_filters):flagis true; the same query withIS TRUEreturns identical results. After the fix,IS FALSEreturns the false rows.Checklist: