chore: bump Node to 24 LTS, unify CI on .nvmrc - #357
Merged
Conversation
Node 20 has been EOL since April 2026, and .nvmrc (20.19.0) was already too old for react-native 0.86 — six CI jobs worked around it with their own node-version: 22 pins. Bump .nvmrc to v24.18.0 (active LTS) and point those jobs back at .nvmrc so there is a single source of truth again. Verified under Node 24: yarn install, typecheck, lint, and the full jest suite. Also unblocks running TypeScript scripts directly with node (>=22.18 strips types by default), reducing the need for alternate runtimes.
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Node.js baseline to Node 24 LTS and makes GitHub Actions CI consistently derive its Node version from .nvmrc, restoring a single source of truth across jobs.
Changes:
- Bump
.nvmrcfromv20.19.0tov24.18.0. - Replace multiple
actions/setup-nodenode-version: 22pins withnode-version-file: .nvmrcacross CI jobs. - Remove the prior “override Node here only” rationale (but one related comment/step label needs updating—see review comments).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.nvmrc |
Updates the project’s canonical Node version to v24.18.0. |
.github/workflows/ci.yml |
Switches CI jobs from hard-pinned Node 22 to reading the version from .nvmrc for consistency. |
Comments suppressed due to low confidence (4)
.github/workflows/ci.yml:290
- This step name still says "Use Node 22" but it now uses node-version-file: .nvmrc. Renaming it keeps the workflow output accurate.
- name: Use Node 22
.github/workflows/ci.yml:524
- This step name still says "Use Node 22" but the workflow now reads the version from .nvmrc. Update the name to reflect the new configuration.
- name: Use Node 22
.github/workflows/ci.yml:626
- This step name still says "Use Node 22" even though it now uses node-version-file: .nvmrc. Renaming it avoids confusion when reviewing CI logs.
- name: Use Node 22
.github/workflows/ci.yml:860
- This step name still says "Use Node 22" but the workflow now sources the version from .nvmrc. Rename it so the logs reflect the actual configuration.
- name: Use Node 22
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The Setup composite action already runs actions/setup-node with
node-version-file: .nvmrc, so once these six steps stopped pinning
node-version: 22 they became exact no-ops — same action, same input,
a few lines after Setup had already applied it.
Remove them along with their comments, which had gone stale in the same
move: the step names still read "Use Node 22" while installing 24, one
comment was left a bare fragment ("for expo prebuild/codegen, so
override node here only"), and the rest cited "requires node ^20.19.4"
in a way that reads as contradicting the .nvmrc pin.
Node still comes from .nvmrc in every job via Setup, which runs
unconditionally ahead of the removed steps.
mfazekas
enabled auto-merge (squash)
July 30, 2026 06:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 20 has been EOL since April 2026, and .nvmrc (20.19.0) was already too old for react-native 0.86 — six CI jobs worked around it with their own node-version: 22 pins. This bumps .nvmrc to v24.18.0 (active LTS, maintained to April 2028) and points those jobs back at node-version-file: .nvmrc, restoring a single source of truth.
Verified locally under Node 24 LTS: yarn install, typecheck, lint, full jest suite, and (on the #352 branch) the schema generator scripts run natively including WASM extraction, with byte-identical output. Follow-up to the Bun discussion in #352 — with Node 24, TypeScript scripts run directly via node, so Bun becomes a dev convenience rather than a requirement.