fix: back to kv/v1 DTOs with RFC3339 string TTLs - #136
Open
rustatian wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the KV RPC wire types back to kv/v1 DTOs and restores TTL transport as RFC3339 strings to match the v1 ecosystem expectations (spiral/roadrunner-kv v4 + released PHP packages), while bumping api-go to v6.0.0-beta.14.
Changes:
- Switch RPC layer request/response/item types from
api-go/kv/v2toapi-go/kv/v1. - Change TTL handling to pass RFC3339 timeout strings through on the wire (
Item.Timeout) instead of converting to/from protobufDuration. - Bump
github.com/roadrunner-server/api-go/v6dependency tov6.0.0-beta.14(root + tests modules), and adjust protobuf requirement to indirect.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
rpc.go |
Replaces kv/v2 DTOs with kv/v1 and switches TTL wire format to RFC3339 strings. |
tests/kv_plugin_test.go |
Updates RPC integration tests to call KV endpoints using kv/v1 request/response types. |
go.mod |
Bumps api-go to v6.0.0-beta.14 and moves protobuf to indirect. |
go.sum |
Updates checksums for the api-go version bump. |
tests/go.mod |
Bumps api-go to v6.0.0-beta.14 in the tests module. |
tests/go.sum |
Updates checksums for the tests module’s api-go version bump. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 54.18% 56.48% +2.29%
==========================================
Files 3 3
Lines 227 216 -11
==========================================
- Hits 123 122 -1
+ Misses 96 87 -9
+ Partials 8 7 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rustatian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPC layer back on kv/v1 messages; TTLs travel as RFC3339 strings again, matching spiral/roadrunner-kv v4.
Part of the v1 proto revert (roadrunner-server/api#77, roadrunner-server/api-go#35): wire format back to what roadrunner-api-dto v1.14.1 and the released PHP packages speak. Pins api-go v6.0.0-beta.14. Tests temporarily pin sibling revert branches via pseudo-versions; they will be bumped to the new betas once tagged.