Skip to content

fix(runner): preserve multiline message text in results truncation #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kemilsoderberg wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −8
Open

fix(runner): preserve multiline message text in results truncation #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions packages/runner/src/robotcode/runner/cli/results/results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,10 +1146,11 @@ def _make_diff_change(
def _truncate(text: Optional[str], limit: int) -> Optional[str]:
if not text:
return None
first_line = text.splitlines()[0]
if limit and len(first_line) > limit:
return first_line[:limit].rstrip() + "…"
return first_line
if not limit:
return text
if len(text) > limit:
return text[:limit].rstrip() + "…"
return text


def _resolve_profile(app: Application) -> Tuple[RobotBaseProfile, Optional[Path]]:
Expand Down Expand Up @@ -1529,11 +1530,11 @@ def _make_file_info(path: Path) -> ResultFileInfo:

def _make_test_item(test: TestCase, *, message_chars: int) -> TestResultItem:
msg = test.message or ""
first_line = msg.splitlines()[0] if msg else ""
truncated_msg = first_line
full_msg: Optional[str] = None
if message_chars and len(first_line) > message_chars:
truncated_msg = first_line[:message_chars]
if message_chars and len(msg) > message_chars:
truncated_msg = msg[:message_chars]
else:
truncated_msg = msg
if msg and (truncated_msg != msg):
full_msg = msg

Expand Down