Fix LOAD_COMMON_CONSTANT argrepr behavior on 3.15#191
Merged
Conversation
Owner
|
This is apparently a recent addition to Python 3.15. I am not seeing it in 3.15.0a7. LGTM though. Verified on 3.15.0b3. |
Owner
|
BTW. Unrelated. The other day I was listing 3.14 instructions, and I see that disassembly is not showing the argument value on a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 3.15,
argreprindishas been adjusted to the actualLOAD_COMMON_CONSTANTvalues, unlike 3.14 where they are still integers. This causes a parity mismatch betweenxdisanddison 3.15.This PR fixes this parity issue by adding a hook in
bytecode.pyand updatingopcode_315.pyto useLOAD_COMMON_CONSTANTvalues forargval, and changingargreprto userepr(argval)to avoid the need for 2LOAD_COMMON_CONSTANTtables.Issue reproduction
Output on 3.15: