[ntuple] Rename kTypeDAOS to kTypeObject64 and kTypeS3 to kTypeMulti#22434
Merged
Conversation
jblomer
reviewed
Jun 2, 2026
Test Results 22 files 22 suites 3d 12h 8m 10s ⏱️ Results for commit 2fca8ca. ♻️ This comment has been updated with latest results. |
JasMehta08
force-pushed
the
locator-type-rename
branch
from
38138a6 to
d796341
Compare
hahnjo
reviewed
Jun 3, 2026
JasMehta08
force-pushed
the
locator-type-rename
branch
from
d796341 to
2fca8ca
Compare
jblomer
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Consolidate locator type naming as suggested in the review of PR #22351.
kTypeDAOSis renamed tokTypeObject64since it is used by both DAOS and S3 Mode B backends.kTypeS3is renamed tokTypeMultisince it represents a multi-field packed locator. Wire format values (0x02 and 0x03) are unchanged.Updated
BinaryFormatSpecification.mdto register locator types 0x02 (Object64) and 0x03 (Multi) in the type table, and added an Object64 payload format diagram to the well-known payload formats section describing the shared layout used by both types.Checklist:
This PR is a follow-up to #22351