[nfc][io] clarify how to check for health status of TFile#22477
Open
ferdymercury wants to merge 5 commits into
Open
[nfc][io] clarify how to check for health status of TFile#22477ferdymercury wants to merge 5 commits into
ferdymercury wants to merge 5 commits into
Conversation
ferdymercury
added
skip ci
ferdymercury
commented
Jun 4, 2026
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 2f03964. ♻️ This comment has been updated with latest results. |
Member
|
I think we should wait for @pcanal's comments before going forward with this. |
pcanal
reviewed
Jun 4, 2026
pcanal
reviewed
Jun 4, 2026
pcanal
approved these changes
Jun 4, 2026
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
LGTM (see minor additional informations added).
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
vepadulano
requested changes
Jun 5, 2026
| /// | ||
| /// To check for the health status of a TFile and detect corruption, you can perform the following checks after opening it: | ||
| /// ~~~{.cpp} | ||
| /// TFile *f = TFile::Open("name.root", "READ"); |
Member
There was a problem hiding this comment.
Suggested change
| /// TFile *f = TFile::Open("name.root", "READ"); | |
| /// std::unique_ptr<TFile> f{TFile::Open("name.root", "READ")}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22464