Skip to content

Preserve iterable executable arguments - #988

Open
Old-Ding wants to merge 2 commits into
ros2:rollingfrom
Old-Ding:codex/materialize-executable-arguments
Open

Preserve iterable executable arguments#988
Old-Ding wants to merge 2 commits into
ros2:rollingfrom
Old-Ding:codex/materialize-executable-arguments

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 11, 2026

Copy link
Copy Markdown

Summary

  • materialize Executable.arguments and each nested argument iterable once at construction
  • build the command and expose the public property from the same stored values
  • prevent one-shot outer or nested argument iterables from appearing empty after normalization

Testing

  • focused runtime probe reproduced a nested generator producing the correct command token while leaving arguments empty before the fix
  • launch/test/launch/test_executable.py: 8 passed
  • ament_flake8, ament_pep257, and ament_copyright on both modified files
  • targeted mypy on launch/launch/descriptions/executable.py
  • python -m py_compile on both modified files
  • git diff --check

Materialize extra arguments once so command construction does not exhaust
the iterable exposed by the public arguments property.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@mergify

mergify Bot commented Jul 11, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Materialize each nested argument iterable before command construction so
the public arguments property retains the values consumed by normalization.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant