Mjcarroll/windows socket exhaustion#1241
Conversation
Try to cure windows socket exhaustion issues we are seeing in CI Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com>
…event socket exhaustion Check if daemon is already running in spawn_daemon() before trying to bind. This preserves the single-daemon constraint while allowing allow_reuse_address to be True and enabling SO_REUSEADDR socket option on all platforms (including Windows). This fixes WSAEADDRINUSE / WinError 10055 socket exhaustion during TCP TIME_WAIT states. Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Assisted-by: Gemini CLI:Gemini 3.5 Flash [view_file, grep_search, list_dir, search_web, run_command, replace_file_content]
91681f8 to
0b73f57
Compare
fujitatomoya
left a comment
There was a problem hiding this comment.
fix looks good, but i am not 100% sure if this solves the problem for the windows...
starting CI to see if what is gonna happen 👀
|
Pulls: #1241 |
Yeah, at this point I'm kind of just attempting things to see if it makes a difference. It does seem that the real underlying cause is that we are running out of sockets on Windows. Based on my reading, sockets will still live for a few minutes after a process terminates, so I'm experimenting with more aggressively cleaning them up before we shutdown. |
Description
A few fixes to try to clear up Windows socket exhaustion issues.
Fixes #1229
Is this user-facing behavior change?
No
Did you use Generative AI?
Assissted-by: Antigravity CLI (Gemini 3.5 Flash)
Additional Information