chore(mise): generate schema clients before typechecking - #82
Merged
Conversation
Contributor
|
roziscoding
force-pushed
the
chore/typecheck-generates-clients
branch
from
July 31, 2026 23:27
8923499 to
4747008
Compare
packages/schemas/src/generated is gitignored, so a fresh checkout typechecks against clients that don't exist yet: ~13 errors like "Cannot find module '@jack/schemas/radarr/types'" plus the implicit-anys they cascade into, all of which read like a regression in whatever you last touched. The dependency goes on typecheck:backend and typecheck:workspace — the two tasks that actually consume the generated types — so running either one directly is fixed too, not just the `mise run typecheck` aggregate. It depends on `clients:generate` rather than `clients` so it skips the clean: generating over existing output is idempotent, which keeps it cheap to repeat on every run. mise dedupes the shared dependency, so a full typecheck generates once.
roziscoding
force-pushed
the
chore/typecheck-generates-clients
branch
from
August 1, 2026 00:18
4747008 to
32145c2
Compare
roziscoding
enabled auto-merge (squash)
August 1, 2026 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
mise run typecheckgenerate the schema clients it depends on.packages/schemas/src/generated/is gitignored, so on a fresh checkout typecheck runs against clients that don't exist yet and fails with ~13 errors:Nothing is wrong —
mise run clientsjust hasn't run. But the errors point at real source files and read like a regression in whatever you last touched, which is a bad first five minutes on a new machine. (It cost me exactly that this week.)The dependency goes on
typecheck:backendandtypecheck:workspacerather than thetypecheckaggregate, because those are the two tasks that actually consume the generated types — so running either directly is fixed too, not just the umbrella task.typecheck:uidoesn't touch them and is left alone.It depends on
clients:generaterather thanclients, which skips therm -rfthatclientsdoes first. Generating over existing output is idempotent, so repeating it on every typecheck costs ~350 ms per schema against checked-in*.openapi.jsonfiles, with no network and no wiping of files that were already fine.Related issue
Checklist
mise run lint:fixwas run and its output is committed (no changes)mise run testpasses — unaffected by this change;bun testnever needed the generated clients.mise run test:e2enot run: no Docker in the dev environment.Verification
Wiped
packages/schemas/src/generated/and confirmed every entry point recovers on its own:mise run typecheck— exit 0, andclients:generateran once for both dependent tasks (mise dedupes the shared dependency)mise run typecheckimmediately after — exit 0, so regenerating over existing output is safemise run typecheck:backendon its own — exit 0