"info recording" command that gives the path to the recording#4085
Open
timo wants to merge 1 commit into
Open
Conversation
rocallahan
requested changes
Jul 21, 2026
rocallahan
left a comment
rocallahan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good modulo these minor comments.
Collaborator
There was a problem hiding this comment.
I don't think you need your own test program here. You can use simple.c like when.run does.
| [](GdbServer&, Task* t, const vector<string>&) { | ||
| if (!t->session().is_replaying()) { | ||
| return DebuggerExtensionCommandHandler::cmd_end_diversion(); | ||
| } |
Collaborator
There was a problem hiding this comment.
I don't think you need to end the diversion for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
info recording prints out the path of the recording folder.
This is useful for running additional rr replay sessions from an existing one, or for calling rr dump to get data that is not otherwise surfaced by any gdb commands.