Add Inventory Instruments and Instrument Templates support#51
Merged
Conversation
RSpace 2.24 introduced Instruments as a native Inventory item type, created from Instrument Templates (the same record/template relationship that Samples have with Sample Templates). This adds first-class client support so the feature can be consumed by scripts and the RSpace MCP server. - inv.py: wire IN/NT global-id prefixes into the Id class (making rename, set_image, duplicate, add_extra_fields and upload_attachment work on instruments for free); add INSTRUMENT/INSTRUMENT_TEMPLATE to ResultType; add InstrumentPost and full CRUD/restore/owner-transfer/revision/version methods for instruments and instrument templates on InventoryClient. - template_builder.py: extract the shared field-definition methods into a FieldDefinitionBuilder base class and add InstrumentTemplateBuilder alongside the unchanged TemplateBuilder. - Tests: unit coverage for IN/NT id handling and InstrumentTemplateBuilder, plus live integration tests for instrument + instrument template CRUD (verified green against demos.researchspace.com). - examples/create_instrument.py and CHANGELOG entry; bump version to 2.7.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
@nebay-abraha could you check out the test failure? seems like a dependency is not loaded. |
Contributor
@tilorspace , this issue is fixed here Open PR , in your branch --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSpace 2.24 introduced Instruments as a native Inventory item type, created from Instrument Templates (the same record/template relationship that Samples have with Sample Templates). This adds first-class client support so the feature can be consumed by scripts and the RSpace MCP server.