Skip to content

chore(deps): upgrade Rslint to v0.8.0 - #105

Open
chenjiahan wants to merge 2 commits into
mainfrom
chore/upgrade-rslint-0.8
Open

chore(deps): upgrade Rslint to v0.8.0#105
chenjiahan wants to merge 2 commits into
mainfrom
chore/upgrade-rslint-0.8

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

  • Upgrade @rslint/core to v0.8.0 and refresh the lockfile where applicable.
  • Preserve the existing recommended-rule coverage under Rslint 0.8.
  • Resolve newly surfaced lint diagnostics where needed.
  • Verify the relevant lint checks pass.

Related Links

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e9c5475b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rslint.config.ts
Comment on lines +7 to +9
files: ['playground/**/*', 'test/**/*'],
rules: {
'no-undef': 'off',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Scope the no-undef exception to files needing globals

This override disables no-undef for every file under both directories, including browser-side JavaScript fixtures such as playground/src/index.js and test/*/src/*.js. Consequently, a misspelled identifier or missing import in those files will pass pnpm lint, defeating part of the newly added recommended JavaScript rules. Narrow the exception to the configuration files that rely on environment globals such as process or __dirname, or declare those globals explicitly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant