Fix CI#358
Merged
Merged
Conversation
The threadsafety test in memoized_helpers_spec.rb intermittently fails with ThreadOrder::CannotResume due to thread scheduling timing, not because of rufo's formatting. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bundler is the tool that loads the Gemfile itself, so pinning it as a gem dependency is unnecessary. With Gemfile requiring bundler >= 2.5.23, CI failed on Ruby 3.0/3.1/3.2/3.3 where the system-shipped bundler is older. Removing the entry lets each Ruby version use its bundled bundler. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Lint/AmbiguousRange (formatter.rb x4): wrap the lhs of complex range expressions in parens, e.g. (line + 1..@line) -> ((line + 1)..@line). - Lint/UselessConstantScoping (erb_formatter.rb): mark CODE_BLOCK_KEYWORDS with private_constant so its visibility matches the surrounding private section. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kzkn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three CI failures that surfaced after the dev-dependency bump in 3629816.
memoized_helpers_spec.rbfrom sample-code verification (45d7f36) —ThreadOrder::CannotResumeis a timing flake in rspec-core's threadsafety test, not a rufo regression.bundlerfromGemfile(cbbf063) —bundler >= 2.5.23is unsatisfiable with the bundler shipped on Ruby 3.0/3.1/3.2/3.3. The entry isn't needed.Lint/AmbiguousRangex4 andLint/UselessConstantScopingx1.🤖 Generated with Claude Code