Replace deprecated stellar contract bindings json with stellar contract info interface#112
Open
bbyalcinkaya wants to merge 10 commits into
Open
Replace deprecated stellar contract bindings json with stellar contract info interface#112bbyalcinkaya wants to merge 10 commits into
stellar contract bindings json with stellar contract info interface#112bbyalcinkaya wants to merge 10 commits into
Conversation
juliankuners
approved these changes
Jun 15, 2026
juliankuners
left a comment
juliankuners
left a comment
Contributor
There was a problem hiding this comment.
See comments, otherwise LGTM
| def _from_dict(cls: type[SCVecType], d: dict[str, Any]) -> SCVecType: | ||
| return SCVecType(SCType.from_dict(d['element'])) | ||
| def _from_xdr_json(cls: type[SCVecType], x: str | dict[str, Any]) -> SCVecType: | ||
| assert isinstance(x, dict) |
Contributor
There was a problem hiding this comment.
This should be a ValueError.
| key = SCType.from_dict(d['key']) | ||
| value = SCType.from_dict(d['value']) | ||
| def _from_xdr_json(cls: type[SCMapType], x: str | dict[str, Any]) -> SCMapType: | ||
| assert isinstance(x, dict) |
Contributor
There was a problem hiding this comment.
Also ValueError instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stellar contract bindings jsoncommand has been deprecated.Switch to
stellar contract info interface --output jsonfor extracting contract interfaces from Wasm (Stellar CLI Manual).The new command returns the interface in XDR-JSON format.
Update the parsing logic to consume this format and adapt type decoding accordingly.
No functional change in Komet’s internal representation; only the input format and extraction method are updated.
Note: Unit tests in CI run outside Docker and without kompilation, so some refactoring was needed to prevent KDefinitions from being loaded during Python module import. Reviewing commit by commit may be easier, since the PR includes both the interface migration and the related test/import refactoring.