Skip to content

Add FileCheck annotations to mir-opt/copy-prop#135099

Merged
bors merged 14 commits into
rust-lang:masterfrom
Shunpoco:116971-mir-opt-copy-prop
Nov 3, 2025
Merged

Add FileCheck annotations to mir-opt/copy-prop#135099
bors merged 14 commits into
rust-lang:masterfrom
Shunpoco:116971-mir-opt-copy-prop

Conversation

@Shunpoco

@Shunpoco Shunpoco commented Jan 4, 2025

Copy link
Copy Markdown
Contributor

This resolves a part of #116971 .

This PR adds FileCheck annotations to test files under mir-opt/copy-prop.

@rustbot

rustbot commented Jan 4, 2025

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2025
Shunpoco
Shunpoco commented Jan 4, 2025
View reviewed changes
Comment thread tests/mir-opt/copy-prop/copy_propagation_arg.rs
Shunpoco
Shunpoco commented Jan 4, 2025
View reviewed changes
Comment thread tests/mir-opt/copy-prop/partial_init.rs
@Shunpoco Shunpoco marked this pull request as ready for review January 4, 2025 13:16
@Shunpoco

Shunpoco commented Jan 4, 2025

Copy link
Copy Markdown
Contributor Author

r? @cjgillot

@rustbot rustbot assigned cjgillot and unassigned Mark-Simulacrum Jan 4, 2025
cjgillot
cjgillot reviewed Jan 8, 2025
View reviewed changes

@cjgillot cjgillot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the great work. A few nits.

Comment thread tests/mir-opt/copy-prop/calls.rs
Comment thread tests/mir-opt/copy-prop/calls.rs
Comment thread tests/mir-opt/copy-prop/copy_propagation_arg.rs
Comment thread tests/mir-opt/copy-prop/cycle.rs Outdated
Comment thread tests/mir-opt/copy-prop/dead_stores_better.rs Outdated
Comment thread tests/mir-opt/copy-prop/issue_107511.rs Outdated
Comment thread tests/mir-opt/copy-prop/move_projection.rs Outdated
Comment thread tests/mir-opt/copy-prop/partial_init.rs
@apiraino

apiraino commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

r? compiler

@rustbot rustbot assigned BoxyUwU and unassigned cjgillot Apr 8, 2025
@BoxyUwU

BoxyUwU commented Apr 8, 2025

Copy link
Copy Markdown
Member

r? @jieyouxu
weird test stuff

@rustbot rustbot assigned jieyouxu and unassigned BoxyUwU Apr 8, 2025
jieyouxu
jieyouxu reviewed Apr 8, 2025
View reviewed changes

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FileCheck annotations syntactically look okay but I don't know mir-opts well so rerolling a mir-opt reviewer.

@jieyouxu

jieyouxu commented Apr 8, 2025

Copy link
Copy Markdown
Member

r? mir-opt

@rustbot rustbot assigned wesleywiser and unassigned jieyouxu Apr 8, 2025
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc A-mir-opt Area: MIR optimizations labels Apr 8, 2025
wesleywiser
wesleywiser reviewed Apr 18, 2025
View reviewed changes
Comment thread tests/mir-opt/copy-prop/dead_stores_better.rs Outdated
@wesleywiser

wesleywiser commented Oct 16, 2025

Copy link
Copy Markdown
Member

r? rust-lang/compiler

@rustbot rustbot assigned davidtwco and unassigned wesleywiser Oct 16, 2025
davidtwco
davidtwco approved these changes Oct 25, 2025
View reviewed changes

@davidtwco davidtwco left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, replied to another review comment then r=me

View changes since this review

@Shunpoco Shunpoco force-pushed the 116971-mir-opt-copy-prop branch from 7a64137 to b30493b Compare October 26, 2025 10:38
@rustbot

rustbot commented Oct 26, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jieyouxu

jieyouxu commented Oct 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Can you please squash or otherwise reorganize the commits a bit? 20+ commits seems unnecessary.

@Shunpoco Shunpoco force-pushed the 116971-mir-opt-copy-prop branch from b30493b to 620b9b1 Compare October 26, 2025 10:59
@davidtwco

davidtwco commented Nov 3, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 620b9b1 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 3, 2025
Merged
@bors bors merged commit c97bde7 into rust-lang:master Nov 3, 2025
@rustbot rustbot added this to the 1.93.0 milestone Nov 3, 2025
@Shunpoco Shunpoco deleted the 116971-mir-opt-copy-prop branch November 3, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser left review comments
@cjgillot cjgillot cjgillot left review comments
@jieyouxu jieyouxu jieyouxu left review comments
@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

A-mir-opt Area: MIR optimizations A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

10 participants

@Shunpoco @rustbot @apiraino @BoxyUwU @jieyouxu @wesleywiser @davidtwco @bors @cjgillot @Mark-Simulacrum