Implement Box::as_non_null().#157347
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
6 tasks
Contributor
Author
|
I'm unsure about |
This comment has been minimized.
This comment has been minimized.
ACP: <rust-lang/libs-team#799> Tracking issue: <rust-lang#157345> The docs are mostly copied from `Box::as_mut_ptr()`
theemathas
force-pushed
the
box-as-non-null
branch
from
021f8ba to
5a39872
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rustbot reroll |
Contributor
Author
|
I think that |
Contributor
Author
|
I'm told that libs-api doesn't do reviews. Oops. r? libs |
Darksonn
approved these changes
Jun 30, 2026
Member
There was a problem hiding this comment.
Looks good to me. I agree with the PRs current choice of annotating with #[rustc_as_ptr] but not #[rustc_never_returns_null_ptr].
@bors r+ rollup
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 30, 2026
…sonn Implement `Box::as_non_null()`. ACP: <rust-lang/libs-team#799> Tracking issue: <rust-lang#157345> The docs are mostly copied from `Box::as_mut_ptr()` I also made a drive-by change to add `#[must_use]` to `Box::as_{ptr, mut_ptr}`. I'm unsure what `#[rustc_never_returns_null_ptr]` and `#[rustc_as_ptr]` do. Should `Box::as_non_null()` be annotated with them? r? libs-api
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 30, 2026
…uwer Rollup of 7 pull requests Successful merges: - #156379 (lint on `core::ffi::c_void` as a return type) - #157347 (Implement `Box::as_non_null()`.) - #157650 (rustc_target: Add OpenEmbedded/Yocto Linux base targets) - #158569 ([rustdoc] Fix handling of inlining of `no_inline` of foreign items) - #158573 (stabilize `feature(atomic_from_mut)`) - #158614 (Fix error message when rejecting implicit stage != 2 in CI) - #158616 (Remove dependency from `rustc_metadata` on `rustc_incremental`)
rust-timer
added a commit
that referenced
this pull request
Jul 1, 2026
Rollup merge of #157347 - theemathas:box-as-non-null, r=Darksonn Implement `Box::as_non_null()`. ACP: <rust-lang/libs-team#799> Tracking issue: <#157345> The docs are mostly copied from `Box::as_mut_ptr()` I also made a drive-by change to add `#[must_use]` to `Box::as_{ptr, mut_ptr}`. I'm unsure what `#[rustc_never_returns_null_ptr]` and `#[rustc_as_ptr]` do. Should `Box::as_non_null()` be annotated with them? r? libs-api
bjorn3
pushed a commit
to bjorn3/miri
that referenced
this pull request
Jul 1, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#156379 (lint on `core::ffi::c_void` as a return type) - rust-lang/rust#157347 (Implement `Box::as_non_null()`.) - rust-lang/rust#157650 (rustc_target: Add OpenEmbedded/Yocto Linux base targets) - rust-lang/rust#158569 ([rustdoc] Fix handling of inlining of `no_inline` of foreign items) - rust-lang/rust#158573 (stabilize `feature(atomic_from_mut)`) - rust-lang/rust#158614 (Fix error message when rejecting implicit stage != 2 in CI) - rust-lang/rust#158616 (Remove dependency from `rustc_metadata` on `rustc_incremental`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#799
Tracking issue: #157345
The docs are mostly copied from
Box::as_mut_ptr()I also made a drive-by change to add
#[must_use]toBox::as_{ptr, mut_ptr}.I'm unsure what
#[rustc_never_returns_null_ptr]and#[rustc_as_ptr]do. ShouldBox::as_non_null()be annotated with them?r? libs-api