Emit retags in codegen to support BorrowSanitizer (part 4)

[icmccorm]

Tracking issue: #154760
Zulip Thread

This is one of several PRs that add experimental support for emitting retags as function calls in codegen.

This PR emits our retag intrinsics based on the structure of a RetagPlan. The feature works end-to-end now! But, it has two limitations:

• We do not track interior mutable or pinned ranges precisely. This will come in the next PR, which should be the last one that we need to complete this feature (excluding documentation and compile tests).

• We recurse into repr(simd) types when building a RetagPlan, but we do not emit retags for their fields. We would need BuilderMethods::insert_element, which isn't available. I'm not sure what the best workaround would be for this.

Related: #157825, #156210, #156208

Cc: @RalfJung
r? @saethlin

[saethlin]

I don't think this is quite right. For example:

#![crate_type = "lib"]

pub enum Inner {
    A(&'static u8),
    B(&'static u16),
}

pub enum Outer {
    P(&'static u32),
    Q(Inner),
}

#[inline(never)]
pub fn demo(_x: Outer) {}

produces a block for the Outer::Q case that recurses into the Inner, but that block has no predecessors.

View changes since the review

[icmccorm]

Good catch! This should be fixed now with 19ba1b0.

[saethlin]

@bors squash

[rust-bors]

🔑 The Allow edits by maintainers option is not enabled on this PR. It is required for squashing to work.

[saethlin]

Oof. @icmccorm Can you combine the commits into perhaps two commits, or check the box that lets maintainers push changes?

Then r=me

[icmccorm]

@saethlin I squashed this into two commits.

Since our fork is under an org, GitHub doesn't support letting maintainers make changes, unless I add each individual maintainer to the org. I can add you, if you like. Otherwise, I can just do this from a personal fork in the future.

[saethlin]

Since our fork is under an org, GitHub doesn't support letting maintainers make changes, unless I add each individual maintainer to the org. I can add you, if you like. Otherwise, I can just do this from a personal fork in the future.

That's very unfortunate. Don't bother changing your workflow around this limitation, I'll just be ready for it in the future :p

[saethlin]

@bors r+

[rust-bors]

📌 Commit c268765 has been approved by saethlin

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.