rustdoc: Show use-site paths for unevaluated const array lengths#158334
Open
lapla-cogito wants to merge 1 commit into
Open
rustdoc: Show use-site paths for unevaluated const array lengths#158334lapla-cogito wants to merge 1 commit into
lapla-cogito wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lapla-cogito
force-pushed
the
rustdoc_typeconst
branch
from
82c6679 to
bf39c1b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lapla-cogito
force-pushed
the
rustdoc_typeconst
branch
from
bf39c1b to
9f9b0f0
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
camelid
reviewed
Jun 29, 2026
| inline::print_inlined_const(tcx, def_id) | ||
| } | ||
| ty::ConstKind::Alias(_, ty::AliasConst { kind, .. }) => { | ||
| let def_id = kind.opt_def_id().unwrap(); |
Member
There was a problem hiding this comment.
This function is weird since it returns Option but is always Some currently... not sure what's up with that. Could you change this to match exhaustively on the kind to extract the DefId, so that we don't end up with ICEs in the function is changed? No need to change the code below, just this let.
camelid
added
S-waiting-on-author
lapla-cogito
force-pushed
the
rustdoc_typeconst
branch
from
9f9b0f0 to
1f4b09e
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #158171, I noticed a few additional issues with the rendering of consts in rustdoc. This PR fixes them. When rendering array lengths, avoid inlining the full definition of unevaluated constants via
print_inlined_const. Instead, fall back toConst::to_string()for use-site rendering, matching the behavior already used for projections without bodies.r? camelid