Move std::io::Seek to core::io#158540
Open
bushrat011899 wants to merge 4 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
the
S-blocked
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jun 29, 2026
rustbot
removed
the
S-waiting-on-review
bushrat011899
force-pushed
the
core_io_seek
branch
from
3fc3098 to
1204962
Compare
clarfonthey
reviewed
Jul 2, 2026
Contributor
|
LGTM minus the docs I mentioned. r? @clarfonthey |
rustbot
added
the
S-waiting-on-review
Contributor
|
r=me once #158539 is merged into main and this gets appropriately rebased after. (Thank you!) |
clarfonthey
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>
bushrat011899
force-pushed
the
core_io_seek
branch
from
327a617 to
6a69276
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@clarfonthey rebased and ready to go! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158539
Description
Moves
std::io::SeekandSeekFromtocore::io. This is a pretty simple migration, but it is blocked by #158539.Notes
alloc::ioandcore::io#154046 (comment) for a review order and broader context for this PR.