Skip to content

[rustdoc] Fix handling of inlining of no_inline of foreign items#158569

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
GuillaumeGomez:fix-no_inline-foreign-inlining
Jul 1, 2026
Merged

[rustdoc] Fix handling of inlining of no_inline of foreign items#158569
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
GuillaumeGomez:fix-no_inline-foreign-inlining

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Jun 29, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Fixes #92379.

The magic of reexport_chain (and what happens when we forget to use it 😆 ).

r? @camelid

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jun 29, 2026
@rustbot

rustbot commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

camelid is currently at their maximum review capacity.
They may take a while to respond.

@GuillaumeGomez GuillaumeGomez changed the title Fix handling of inlining of no_inline of foreign items [rustdoc] Fix handling of inlining of no_inline of foreign items Jun 29, 2026
@GuillaumeGomez

GuillaumeGomez commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

Woups, let's pick someone else then.

r? @Urgau

@rustbot rustbot assigned Urgau and unassigned camelid Jun 29, 2026
Urgau
Urgau reviewed Jun 29, 2026
View reviewed changes
Comment thread src/librustdoc/clean/inline.rs
Comment thread src/librustdoc/clean/inline.rs
@Urgau Urgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2026
@GuillaumeGomez GuillaumeGomez force-pushed the fix-no_inline-foreign-inlining branch from bed951f to a5cb0e7 Compare June 29, 2026 21:14
@GuillaumeGomez

GuillaumeGomez commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Added the test as suggested. :)

Urgau
Urgau approved these changes Jun 30, 2026
View reviewed changes

@Urgau Urgau left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

View changes since this review

@Urgau

Urgau commented Jun 30, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 9aba0b6 has been approved by Urgau

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 30, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 30, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 30, 2026
@bors
Auto merge of #158629 - JonathanBrouwer:rollup-42QCg7x, r=JonathanBro…
17aa775 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #156379 (lint on `core::ffi::c_void` as a return type)
 - #157347 (Implement `Box::as_non_null()`.)
 - #157650 (rustc_target: Add OpenEmbedded/Yocto Linux base targets)
 - #158569 ([rustdoc] Fix handling of inlining of `no_inline` of foreign items)
 - #158573 (stabilize `feature(atomic_from_mut)`)
 - #158614 (Fix error message when rejecting implicit stage != 2 in CI)
 - #158616 (Remove dependency from `rustc_metadata` on `rustc_incremental`)
@rust-bors rust-bors Bot merged commit 7a2a130 into rust-lang:main Jul 1, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jul 1, 2026
rust-timer added a commit that referenced this pull request Jul 1, 2026
@rust-timer
Unrolled build for #158569
f15cbcd 
Rollup merge of #158569 - GuillaumeGomez:fix-no_inline-foreign-inlining, r=Urgau

[rustdoc] Fix handling of inlining of `no_inline` of foreign items

Fixes #92379.

The magic of `reexport_chain` (and what happens when we forget to use it 😆 ).

r? @camelid
@panstromek

panstromek commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

for #158629

@rust-timer build f15cbcd profiles=doc

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f15cbcd): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -8.5% [-8.5%, -8.5%] 1
Improvements ✅
(secondary)		 -8.5% [-8.5%, -8.5%] 1
All ❌✅ (primary) -8.5% [-8.5%, -8.5%] 1

Max RSS (memory usage)

Results (primary -1.4%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.2% [0.9%, 1.5%] 2
Regressions ❌
(secondary)		 1.5% [1.2%, 1.8%] 2
Improvements ✅
(primary)		 -6.5% [-6.5%, -6.5%] 1
Improvements ✅
(secondary)		 -5.7% [-5.7%, -5.7%] 1
All ❌✅ (primary) -1.4% [-6.5%, 1.5%] 3

Cycles

Results (primary -6.6%, secondary -7.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -6.6% [-6.6%, -6.6%] 1
Improvements ✅
(secondary)		 -7.8% [-7.8%, -7.8%] 1
All ❌✅ (primary) -6.6% [-6.6%, -6.6%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.565s -> 487.505s (0.40%)
Artifact size: 393.29 MiB -> 393.23 MiB (-0.02%)

bjorn3 pushed a commit to bjorn3/miri that referenced this pull request Jul 1, 2026
@bors
Auto merge of #158629 - JonathanBrouwer:rollup-42QCg7x, r=JonathanBro…
017151f 
…uwer

Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#156379 (lint on `core::ffi::c_void` as a return type)
 - rust-lang/rust#157347 (Implement `Box::as_non_null()`.)
 - rust-lang/rust#157650 (rustc_target: Add OpenEmbedded/Yocto Linux base targets)
 - rust-lang/rust#158569 ([rustdoc] Fix handling of inlining of `no_inline` of foreign items)
 - rust-lang/rust#158573 (stabilize `feature(atomic_from_mut)`)
 - rust-lang/rust#158614 (Fix error message when rejecting implicit stage != 2 in CI)
 - rust-lang/rust#158616 (Remove dependency from `rustc_metadata` on `rustc_incremental`)
@GuillaumeGomez GuillaumeGomez deleted the fix-no_inline-foreign-inlining branch July 1, 2026 10:37
@ogoffart ogoffart mentioned this pull request Jul 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

Funky rustdoc behavior when pub use path_to::Trait as _; for public-in-private item

6 participants

@GuillaumeGomez @rustbot @Urgau @panstromek @rust-timer @camelid