Improve diagnostic for too many super keywords#158585
Open
andrewkernel wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @davidtwco (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
andrewkernel
force-pushed
the
improve-too-many-super-diagnostic
branch
2 times, most recently
from
830e827 to
295ddb8
Compare
davidtwco
approved these changes
Jul 2, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 2, 2026
…r-diagnostic, r=davidtwco Improve diagnostic for too many super keywords Fixes rust-lang#158275 When resolving a path with too many leading `super` segments inside a nested module, include the current module path in the diagnostic. This makes it easier to see where the `super` chain started, especially for generated code or code included from another location. The overflowing `super` label now also explains that it would go above the crate root. Example: ```text error[E0433]: too many leading `super` keywords within `crate::outer::inner` --> tests/ui/resolve/too-many-super-issue-158275.rs:5:38 | LL | struct Example(super::super::super::Impl); | ^^^^^ this `super` would go above the crate root ``` Tests: ```text x.py --build x86_64-pc-windows-gnu --host x86_64-pc-windows-gnu check compiler/rustc_resolve --stage 1 x.py --build x86_64-pc-windows-gnu --host x86_64-pc-windows-gnu test tidy ```
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 3, 2026
…uwer Rollup of 22 pull requests Successful merges: - #155429 (Support `u128`/`i128` c-variadic arguments) - #158100 (Emit retags in codegen to support BorrowSanitizer (part 4)) - #158494 (Improve E0277 diagnostics for conditionally implemented traits) - #158606 (use ProjectionPredicate instead of AliasRelate) - #158627 (Simplify option-iterator flattening in the compiler) - #158658 (Update LLVM submodule) - #158665 (Revert "Remove redundant dyn-compatibility check.") - #158021 (Remove old MinGW workaround) - #158473 (Add `riscv32imfc-unknown-none-elf` bare-metal target) - #158549 (process::exec: using appropriate exit code on vxworks.) - #158585 (Improve diagnostic for too many super keywords) - #158637 (hir_ty_lowering: avoid self type lookup for inherent aliases) - #158651 (ptr doc: reduce use of unsafe block to where needed) - #158669 (Remove `src/tools/test-float-parse/Cargo.lock`) - #158674 (library: Polish transmute's `split_at_stdlib` example) - #158677 (Add extra splat tests) - #158680 (Avoid ICE for `NonZero<char>` in improper_ctypes) - #158681 (Remove unnecessary `Hash` derives from MIR types) - #158682 (Avoid delayed bug for disabled on_type_error arguments) - #158684 (Add missing generic test coverage for ```#[splat]```) - #158687 (Streamline `MacEager`) - #158688 (Cleanup attribute docs and add links to other mentioned attributes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158275
When resolving a path with too many leading
supersegments inside a nested module,include the current module path in the diagnostic. This makes it easier to see where
the
superchain started, especially for generated code or code included fromanother location.
The overflowing
superlabel now also explains that it would go above the crate root.Example:
Tests: