Skip to content

Revert "Remove redundant dyn-compatibility check."#158665

Open
theemathas wants to merge 2 commits into
rust-lang:mainfrom
theemathas:undel-dyn-compat-check
Open

Revert "Remove redundant dyn-compatibility check."#158665
theemathas wants to merge 2 commits into
rust-lang:mainfrom
theemathas:undel-dyn-compat-check

Conversation

@theemathas

@theemathas theemathas commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This reverts commit 5fad8a6.

Fixes #158656

See #158665 (comment) for explanation.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2026
@rustbot

rustbot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

r? @Kivooeo

rustbot has assigned @Kivooeo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, types
  • compiler, types expanded to 73 candidates
  • Random selection from 16 candidates

@fmease

fmease commented Jul 1, 2026

Copy link
Copy Markdown
Member

Could you add a regression test?

Kivooeo
Kivooeo approved these changes Jul 1, 2026
View reviewed changes

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after adding a test

View changes since this review

@theemathas

theemathas commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot r=@Kivooeo

@theemathas

theemathas commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=@Kivooeo

@rust-bors

rust-bors Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2906b05 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2026
@Kivooeo

Kivooeo commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@bors r-

Hold on 😅, I didn't except you will add any comments, I need to check one small thing myself and likely to fix comments

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 2, 2026
@rust-bors

rust-bors Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 2, 2026
@theemathas

theemathas commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Whoops. Sorry.

Kivooeo
Kivooeo reviewed Jul 2, 2026
View reviewed changes

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to remove both comments since this is never reached with new solver

View changes since this review

Comment thread tests/ui/impl-trait/rpit/dyn-in-nested-rpit.rs Outdated
lcnr
lcnr reviewed Jul 2, 2026
View reviewed changes
Comment thread compiler/rustc_trait_selection/src/traits/select/mod.rs Outdated
@theemathas theemathas force-pushed the undel-dyn-compat-check branch from 2906b05 to 50181ca Compare July 2, 2026 08:54
@theemathas

theemathas commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

I've applied the suggested comments, although I still don't quite understand everything that's going on.

This is hopefully ready to merge. Sorry for the trouble.

@theemathas theemathas added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 2, 2026
@Kivooeo

Kivooeo commented Jul 2, 2026

Copy link
Copy Markdown
Member

Thanks!

Sorry for the trouble

There's no trouble at all, it's all right

r=me,lcnr with ci green

@theemathas

theemathas commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=Kivooeo,lcnr

@rust-bors

rust-bors Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 50181ca has been approved by Kivooeo,lcnr

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158665 - theemathas:undel-dyn-compat-check,…
a781ee2 
… r=Kivooeo,lcnr

Revert "Remove redundant dyn-compatibility check."

This reverts commit 5fad8a6.

Fixes rust-lang#158656

See rust-lang#158665 (comment) for explanation.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 2, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request Jul 3, 2026
@bors
Auto merge of #158700 - JonathanBrouwer:rollup-HusuWnV, r=JonathanBro…
34fd20b 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #155429 (Support `u128`/`i128` c-variadic arguments)
 - #158100 (Emit retags in codegen to support BorrowSanitizer (part 4))
 - #158494 (Improve E0277 diagnostics for conditionally implemented traits)
 - #158606 (use ProjectionPredicate instead of AliasRelate)
 - #158627 (Simplify option-iterator flattening in the compiler)
 - #158658 (Update LLVM submodule)
 - #158665 (Revert "Remove redundant dyn-compatibility check.")
 - #158021 (Remove old MinGW workaround)
 - #158473 (Add `riscv32imfc-unknown-none-elf` bare-metal target)
 - #158549 (process::exec: using appropriate exit code on vxworks.)
 - #158585 (Improve diagnostic for too many super keywords)
 - #158637 (hir_ty_lowering: avoid self type lookup for inherent aliases)
 - #158651 (ptr doc: reduce use of unsafe block to where needed)
 - #158669 (Remove `src/tools/test-float-parse/Cargo.lock`)
 - #158674 (library: Polish transmute's `split_at_stdlib` example)
 - #158677 (Add extra splat tests)
 - #158680 (Avoid ICE for `NonZero<char>` in improper_ctypes)
 - #158681 (Remove unnecessary `Hash` derives from MIR types)
 - #158682 (Avoid delayed bug for disabled on_type_error arguments)
 - #158684 (Add missing generic test coverage for ```#[splat]```)
 - #158687 (Streamline `MacEager`)
 - #158688 (Cleanup attribute docs and add links to other mentioned attributes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments
@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ICE]: DynCompatible "should have been handled by fulfillment already" for return-position impl Trait

5 participants

@theemathas @rustbot @fmease @Kivooeo @lcnr