Avoid delayed bug for disabled on_type_error arguments#158682
Open
TaKO8Ki wants to merge 2 commits into
Open
Conversation
Collaborator
|
Some changes occurred to diagnostic attributes. cc @mejrs Some changes occurred in compiler/rustc_attr_parsing |
Collaborator
|
r? @camelid rustbot has assigned @camelid. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JonathanBrouwer
approved these changes
Jul 2, 2026
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 2, 2026
…rgs, r=JonathanBrouwer Avoid delayed bug for disabled on_type_error arguments Fixes rust-lang#158628 This updates the disabled-feature path to call `args.ignore_args()`, matching the behavior of other diagnostic attributes. example: https://github.com/rust-lang/rust/blob/c397dae808f70caebab1fc4e11b3edf7e59f58c7/compiler/rustc_attr_parsing/src/attributes/diagnostic/on_unknown.rs#L13-L21
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 2, 2026
…rgs, r=JonathanBrouwer Avoid delayed bug for disabled on_type_error arguments Fixes rust-lang#158628 This updates the disabled-feature path to call `args.ignore_args()`, matching the behavior of other diagnostic attributes. example: https://github.com/rust-lang/rust/blob/c397dae808f70caebab1fc4e11b3edf7e59f58c7/compiler/rustc_attr_parsing/src/attributes/diagnostic/on_unknown.rs#L13-L21
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
Rollup of 5 pull requests Successful merges: - #155429 (Support `u128`/`i128` c-variadic arguments) - #158627 (Simplify option-iterator flattening in the compiler) - #158669 (Remove `src/tools/test-float-parse/Cargo.lock`) - #158674 (library: Polish transmute's `split_at_stdlib` example) - #158682 (Avoid delayed bug for disabled on_type_error arguments)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 2, 2026
…rgs, r=JonathanBrouwer Avoid delayed bug for disabled on_type_error arguments Fixes rust-lang#158628 This updates the disabled-feature path to call `args.ignore_args()`, matching the behavior of other diagnostic attributes. example: https://github.com/rust-lang/rust/blob/c397dae808f70caebab1fc4e11b3edf7e59f58c7/compiler/rustc_attr_parsing/src/attributes/diagnostic/on_unknown.rs#L13-L21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158628
This updates the disabled-feature path to call
args.ignore_args(), matching the behavior of other diagnostic attributes.example:
rust/compiler/rustc_attr_parsing/src/attributes/diagnostic/on_unknown.rs
Lines 13 to 21 in c397dae