Add missing generic test coverage for #[splat]#158684
Open
Ajay-singh1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ajay Singh <ajaykripa8736968359@gmail.com>
Collaborator
|
Failed to set assignee to
|
rustbot
added
S-waiting-on-review
Contributor
|
Still haven't got the triage or member role yet, so I have to comment to assign myself r? @teor2345 |
Member
|
@bors r=teor2345 rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 2, 2026
…teor2345 Add missing generic test coverage for ```#[splat]``` This PR adds missing test coverage for `#[splat]` that was marked as FIXME in `splat-generics-everywhere.rs`: - Add generic parameter to `BarTrait` (`BarTrait<T>`) - Add `generic_in_tuple` , tests generics inside the splatted tuple - Add `generic_tuple_assoc` , tests assoc functions with splatted generic tuple traits - Add `trait_generic_in_tuple` , tests generics inside splatted tuple on trait methods - Add `trait_generic_tuple` , tests splatted generic tuple trait bounds on trait methods Removes the resolved FIXME comments: - also add generics to the trait - also add assoc/method with splatted generic tuple traits - also add generics inside the splatted tuple CC:- @teor2345 r? @teor2345
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 3, 2026
…uwer Rollup of 22 pull requests Successful merges: - #155429 (Support `u128`/`i128` c-variadic arguments) - #158100 (Emit retags in codegen to support BorrowSanitizer (part 4)) - #158494 (Improve E0277 diagnostics for conditionally implemented traits) - #158606 (use ProjectionPredicate instead of AliasRelate) - #158627 (Simplify option-iterator flattening in the compiler) - #158658 (Update LLVM submodule) - #158665 (Revert "Remove redundant dyn-compatibility check.") - #158021 (Remove old MinGW workaround) - #158473 (Add `riscv32imfc-unknown-none-elf` bare-metal target) - #158549 (process::exec: using appropriate exit code on vxworks.) - #158585 (Improve diagnostic for too many super keywords) - #158637 (hir_ty_lowering: avoid self type lookup for inherent aliases) - #158651 (ptr doc: reduce use of unsafe block to where needed) - #158669 (Remove `src/tools/test-float-parse/Cargo.lock`) - #158674 (library: Polish transmute's `split_at_stdlib` example) - #158677 (Add extra splat tests) - #158680 (Avoid ICE for `NonZero<char>` in improper_ctypes) - #158681 (Remove unnecessary `Hash` derives from MIR types) - #158682 (Avoid delayed bug for disabled on_type_error arguments) - #158684 (Add missing generic test coverage for ```#[splat]```) - #158687 (Streamline `MacEager`) - #158688 (Cleanup attribute docs and add links to other mentioned attributes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing test coverage for
#[splat]that was marked as FIXME insplat-generics-everywhere.rs:BarTrait(BarTrait<T>)generic_in_tuple, tests generics inside the splatted tuplegeneric_tuple_assoc, tests assoc functions with splatted generic tuple traitstrait_generic_in_tuple, tests generics inside splatted tuple on trait methodstrait_generic_tuple, tests splatted generic tuple trait bounds on trait methodsRemoves the resolved FIXME comments:
CC:- @teor2345
r? @teor2345