Skip to content

Update FIXME(static_mut_refs) comments#158730

Open
obeis wants to merge 1 commit into
rust-lang:mainfrom
obeis:raw-pointer-static-mut
Open

Update FIXME(static_mut_refs) comments#158730
obeis wants to merge 1 commit into
rust-lang:mainfrom
obeis:raw-pointer-static-mut

Conversation

@obeis

@obeis obeis commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Close #125035

Update FIXME(static_mut_refs) comment to say: use raw pointers instead of references.

r? @RalfJung

update `FIXME(static_mut_refs)` comment to say: use raw pointers instead
of references.
@rustbot

rustbot commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

miri is developed in its own repository. If possible, consider making this change to rust-lang/miri instead.

cc @rust-lang/miri

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 3, 2026
@rustbot

rustbot commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

RalfJung is not on the review rotation at the moment.
They may take a while to respond.

@RalfJung

RalfJung commented Jul 4, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup
Thanks :)

@rust-bors

rust-bors Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 34df033 has been approved by RalfJung

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 5, 2026
…lfJung

Update `FIXME(static_mut_refs)` comments

Close rust-lang#125035

Update `FIXME(static_mut_refs)` comment to say: use raw pointers instead of references.

r? @RalfJung
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 5, 2026
…lfJung

Update `FIXME(static_mut_refs)` comments

Close rust-lang#125035

Update `FIXME(static_mut_refs)` comment to say: use raw pointers instead of references.

r? @RalfJung
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
…lfJung

Update `FIXME(static_mut_refs)` comments

Close rust-lang#125035

Update `FIXME(static_mut_refs)` comment to say: use raw pointers instead of references.

r? @RalfJung
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
…lfJung

Update `FIXME(static_mut_refs)` comments

Close rust-lang#125035

Update `FIXME(static_mut_refs)` comment to say: use raw pointers instead of references.

r? @RalfJung
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
…lfJung

Update `FIXME(static_mut_refs)` comments

Close rust-lang#125035

Update `FIXME(static_mut_refs)` comment to say: use raw pointers instead of references.

r? @RalfJung
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace uses of #[allow(static_mut_refs)] with SyncUnsafeCell

3 participants