rustdoc: Fix crash when trying to inline foreign item which cannot have attributes#158751
Open
GuillaumeGomez wants to merge 1 commit into
Open
rustdoc: Fix crash when trying to inline foreign item which cannot have attributes#158751GuillaumeGomez wants to merge 1 commit into
GuillaumeGomez wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
GuillaumeGomez
commented
Jul 3, 2026
Urgau
reviewed
Jul 3, 2026
Urgau
reviewed
Jul 3, 2026
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 5, 2026
…g, r=Urgau rustdoc: Fix crash when trying to inline foreign item which cannot have attributes Fixes rust-lang#158686. Problem was that there was no filtering made on the `reexport_chain` items before we tried to query its attributes. And if it's an item which cannot have attributes, it crashed. r? @Urgau
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 5, 2026
…g, r=Urgau rustdoc: Fix crash when trying to inline foreign item which cannot have attributes Fixes rust-lang#158686. Problem was that there was no filtering made on the `reexport_chain` items before we tried to query its attributes. And if it's an item which cannot have attributes, it crashed. r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 5, 2026
…g, r=Urgau rustdoc: Fix crash when trying to inline foreign item which cannot have attributes Fixes rust-lang#158686. Problem was that there was no filtering made on the `reexport_chain` items before we tried to query its attributes. And if it's an item which cannot have attributes, it crashed. r? @Urgau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158686.
Problem was that there was no filtering made on the
reexport_chainitems before we tried to query its attributes. And if it's an item which cannot have attributes, it crashed.r? @Urgau