Skip to content

Use ThinVec more in the AST#158755

Open
nnethercote wants to merge 3 commits into
rust-lang:mainfrom
nnethercote:ast-ThinVec
Open

Use ThinVec more in the AST#158755
nnethercote wants to merge 3 commits into
rust-lang:mainfrom
nnethercote:ast-ThinVec

Conversation

@nnethercote

@nnethercote nnethercote commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

For consistency; it has negligible effects on perf. Details in individual commits.

r? @mejrs

@nnethercote
Add some more AST size assertions
ba53d1b
@nnethercote
Use ThinVec in Expr::OffsetOf
b14e429 
Because we use `ThinVec` rather than `Vec` almost everywhere else in the
AST.
@nnethercote
Use ThinVec in GenericBounds
3a0a977 
Because we use `ThinVec` rather than `Vec` almost everywhere else in the
AST.
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 4, 2026
@nnethercote

nnethercote commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 4, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 4, 2026
@bors
Auto merge of #158755 - nnethercote:ast-ThinVec, r=<try>
973fa09 
Use `ThinVec` more in the AST
@rust-bors

rust-bors Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 973fa09 (973fa097ee83e915d5a9ba83a9cbb259b4573170)
Base parent: c397dae (c397dae808f70caebab1fc4e11b3edf7e59f58c7)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (973fa09): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.3%, secondary -5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.9% [0.8%, 1.0%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)		 -5.6% [-5.7%, -5.5%] 2
All ❌✅ (primary) 0.3% [-1.4%, 1.0%] 4

Cycles

Results (primary 2.2%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.5% [-5.5%, -2.4%] 3
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.944s -> 484.62s (-0.27%)
Artifact size: 393.37 MiB -> 393.83 MiB (0.12%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 4, 2026
@nnethercote nnethercote marked this pull request as ready for review July 4, 2026 12:44
@rustbot

rustbot commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2026
mejrs
mejrs reviewed Jul 4, 2026
View reviewed changes

@mejrs mejrs left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 3a0a977 has been approved by mejrs

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 5, 2026
@jhpratt
Rollup merge of rust-lang#158755 - nnethercote:ast-ThinVec, r=mejrs
9b6e394 
Use `ThinVec` more in the AST

For consistency; it has negligible effects on perf. Details in individual commits.

r? @mejrs
@jhpratt jhpratt mentioned this pull request Jul 5, 2026
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 5, 2026
@jhpratt
Rollup merge of rust-lang#158755 - nnethercote:ast-ThinVec, r=mejrs
aef9bb3 
Use `ThinVec` more in the AST

For consistency; it has negligible effects on perf. Details in individual commits.

r? @mejrs
@jhpratt jhpratt mentioned this pull request Jul 5, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158755 - nnethercote:ast-ThinVec, r=mejrs
ea1c0f3 
Use `ThinVec` more in the AST

For consistency; it has negligible effects on perf. Details in individual commits.

r? @mejrs
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 5, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 5, 2026
@JonathanBrouwer
Rollup merge of rust-lang#158755 - nnethercote:ast-ThinVec, r=mejrs
8b1ee68 
Use `ThinVec` more in the AST

For consistency; it has negligible effects on perf. Details in individual commits.

r? @mejrs
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejrs mejrs mejrs left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mejrs mejrs

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nnethercote @rust-timer @rustbot @mejrs