Fix incorrect tracking issue for read_le/read_be#158757
Open
kpeis695 wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-docs
This comment has been minimized.
This comment has been minimized.
kpeis695
force-pushed
the
fix/read-le-be-tracking-issue-link
branch
from
edb0697 to
81b7302
Compare
The unstable attribute on Read::read_le and Read::read_be pointed to the implementation PR rather than the tracking issue, so the docs on doc.rust-lang.org linked to the wrong page.
kpeis695
force-pushed
the
fix/read-le-be-tracking-issue-link
branch
from
81b7302 to
27935a6
Compare
JohnTitor
approved these changes
Jul 4, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 5, 2026
…ssue-link, r=JohnTitor Fix incorrect tracking issue for `read_le`/`read_be` The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to rust-lang#156983, which is the implementation PR. The tracking issue is rust-lang#156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion. Closes rust-lang#158721 @rustbot label +A-docs +T-libs-api
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 5, 2026
…ssue-link, r=JohnTitor Fix incorrect tracking issue for `read_le`/`read_be` The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to rust-lang#156983, which is the implementation PR. The tracking issue is rust-lang#156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion. Closes rust-lang#158721 @rustbot label +A-docs +T-libs-api
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 5, 2026
…ssue-link, r=JohnTitor Fix incorrect tracking issue for `read_le`/`read_be` The `#[unstable]` attribute on `Read::read_le` and `Read::read_be` pointed to rust-lang#156983, which is the implementation PR. The tracking issue is rust-lang#156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion. Closes rust-lang#158721 @rustbot label +A-docs +T-libs-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#[unstable]attribute onRead::read_leandRead::read_bepointed to #156983, which is the implementation PR. The tracking issue is #156984, so the "issue" link on https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read_le takes readers to a merged PR instead of the open tracking discussion.Closes #158721
@rustbot label +A-docs +T-libs-api