Fix ICE on non-ident path in doc(auto_cfg values)#158765
Open
TaKO8Ki wants to merge 2 commits into
Open
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
Collaborator
|
rustbot has assigned @GuillaumeGomez. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JonathanBrouwer
approved these changes
Jul 4, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
GuillaumeGomez
approved these changes
Jul 4, 2026
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 5, 2026
…n-ident, r=JonathanBrouwer Fix ICE on non-ident path in `doc(auto_cfg values)` Fixes rust-lang#158744 `#[doc(auto_cfg(hide(a, values(::b))))]` could ICE while parsing `values(...)` because the malformed nested meta item did not have a single identifier, but the error path still called `unwrap()` on `sub_item.ident()`.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 5, 2026
…n-ident, r=JonathanBrouwer Fix ICE on non-ident path in `doc(auto_cfg values)` Fixes rust-lang#158744 `#[doc(auto_cfg(hide(a, values(::b))))]` could ICE while parsing `values(...)` because the malformed nested meta item did not have a single identifier, but the error path still called `unwrap()` on `sub_item.ident()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158744
#[doc(auto_cfg(hide(a, values(::b))))]could ICE while parsingvalues(...)because the malformed nested meta item did not have a single identifier, but the error path still calledunwrap()onsub_item.ident().