Weaken guarantee for From<legacy::RangeInclusive> for RangeInclusive#158770
Open
theemathas wants to merge 2 commits into
Open
Weaken guarantee for From<legacy::RangeInclusive> for RangeInclusive#158770theemathas wants to merge 2 commits into
From<legacy::RangeInclusive> for RangeInclusive#158770theemathas wants to merge 2 commits into
Conversation
As per rust-lang#155114 (comment), this `From` impl no longer guarantees panicking for exhausted iterators. Instead, it only guarantees that the conversion will either panic or produce an empty range. This is done so that we can optimize the implementation of `legacy::RangeInclusive` in a way such that we cannot check if it has been exhausted in a generic context without a `Step` and/or `PartialOrd` bound.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JohnTitor
approved these changes
Jul 5, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
|
(not beta-nominated but if the promotion happens meanwhile, please add the label) |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 5, 2026
…=JohnTitor Weaken guarantee for `From<legacy::RangeInclusive> for RangeInclusive` As per rust-lang#155114 (comment), this `From` impl no longer guarantees panicking for exhausted iterators. Instead, it only guarantees that the conversion will either panic or produce an empty range. This is done so that we can optimize the implementation of `legacy::RangeInclusive` in a way such that we cannot check if it has been exhausted in a generic context without a `Step` and/or `PartialOrd` bound. If this PR and/or rust-lang#155114 merges after the 1.98.0 beta branch promotion from the main branch, then this will need a beta backport, since this PR changes the stable guarantee previously made in rust-lang#155421. This PR conflicts with and/or blocks rust-lang#155114.
Contributor
|
@bors try jobs=test-various |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 5, 2026
Weaken guarantee for `From<legacy::RangeInclusive> for RangeInclusive` try-job: test-various
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for e35034e failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Does |
Contributor
|
@bors r- |
rust-bors
Bot
removed
the
S-waiting-on-bors
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#158806), which was unapproved. |
Contributor
Author
|
The test failed because |
Contributor
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 5, 2026
Weaken guarantee for `From<legacy::RangeInclusive> for RangeInclusive`
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #155114 (comment), this
Fromimpl no longer guarantees panicking for exhausted iterators. Instead, it only guarantees that the conversion will either panic or produce an empty range.This is done so that we can optimize the implementation of
legacy::RangeInclusivein a way such that we cannot check if it has been exhausted in a generic context without aStepand/orPartialOrdbound.If this PR and/or #155114 merges after the 1.98.0 beta branch promotion from the main branch, then this will need a beta backport, since this PR changes the stable guarantee previously made in #155421.
This PR conflicts with and/or blocks #155114.