library: expand HashSet::extract_if coverage#158771
Open
ArshLabs wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 5, 2026
…overage, r=jhpratt library: expand HashSet::extract_if coverage adds separate `HashSet::extract_if` tests for empty input, consuming no elements & consuming all elements. the existing test covered one element `true`/`false` predicates but did not check the empty case or the yielded elements when everything is extracted so this keeps the coverage focused on normal public behavior & avoids testing post panic iterator behavior. Tested: - `python x.py fmt --check` - `git diff --check`
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 5, 2026
…overage, r=jhpratt library: expand HashSet::extract_if coverage adds separate `HashSet::extract_if` tests for empty input, consuming no elements & consuming all elements. the existing test covered one element `true`/`false` predicates but did not check the empty case or the yielded elements when everything is extracted so this keeps the coverage focused on normal public behavior & avoids testing post panic iterator behavior. Tested: - `python x.py fmt --check` - `git diff --check`
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 5, 2026
…overage, r=jhpratt library: expand HashSet::extract_if coverage adds separate `HashSet::extract_if` tests for empty input, consuming no elements & consuming all elements. the existing test covered one element `true`/`false` predicates but did not check the empty case or the yielded elements when everything is extracted so this keeps the coverage focused on normal public behavior & avoids testing post panic iterator behavior. Tested: - `python x.py fmt --check` - `git diff --check`
Contributor
|
@bors try jobs=test-various |
Contributor
|
⌛ Trying commit 99b3d11 with merge 2b848b1… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/28742614801 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 5, 2026
…<try> library: expand HashSet::extract_if coverage try-job: test-various
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 5, 2026
…overage, r=jhpratt library: expand HashSet::extract_if coverage adds separate `HashSet::extract_if` tests for empty input, consuming no elements & consuming all elements. the existing test covered one element `true`/`false` predicates but did not check the empty case or the yielded elements when everything is extracted so this keeps the coverage focused on normal public behavior & avoids testing post panic iterator behavior. Tested: - `python x.py fmt --check` - `git diff --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds separate
HashSet::extract_iftests for empty input, consuming no elements & consuming all elements.the existing test covered one element
true/falsepredicates but did not check the empty case or the yielded elements when everything is extracted so this keeps the coverage focused on normal public behavior & avoids testing post panic iterator behavior.Tested:
python x.py fmt --checkgit diff --check