Resolver: Wrap arenas in WorkerLocal

[LorrensP-2158466]

In preperation of parallel import resolution #158845 this pr wraps the resolver arenas in WorkerLocal to ensure we don't need any synchronization to access an arena. This is common in the compiler.

Also, when building the resolution table of an external module, we first create a seperate table and fill that one, after which we replace the empty table with that new table. (Prep Work for #158845)
And a manual inline of define_extern.

r? @petrochenkov

[petrochenkov]

@bors try @rust-timer queue

[petrochenkov]

The PR description needs an update, it's not only about arenas.
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 8921b29 (8921b29e422cc22127146a787dda0186d080d041)
Base parent: 561ea2b (561ea2bfa3022226082e2db39d6ccb241e9e34bc)

[rust-timer]

Finished benchmarking commit (8921b29): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	2
Regressions ❌ (secondary)	0.3%	[0.1%, 0.6%]	16
Improvements ✅ (primary)	-0.4%	[-0.5%, -0.4%]	6
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	6
All ❌✅ (primary)	-0.2%	[-0.5%, 0.3%]	8

Max RSS (memory usage)

Results (primary 1.9%, secondary 1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	6.2%	[6.2%, 6.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	1.9%	[1.9%, 1.9%]	1

Cycles

Results (primary -3.0%, secondary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.147s -> 488.199s (-0.19%)
Artifact size: 388.47 MiB -> 388.92 MiB (0.12%)

[petrochenkov]

Small regressions on two stress benchmarks from worker local arenas.
It's acceptable, and we'll need to integrate resolver into the parallel compiler sooner or later anyway.

[petrochenkov]

The build reduced graph changes are potential micro-optimizations (that's where the diesel improvements come from), and the worker local changes are pessimizations, ideally they'd be benchmarked separately.

[LorrensP-2158466]

Force-pushed the comments to keep it one commit. @rustbot ready

ideally they'd be benchmarked separately.

would you like 2 separate prs?

[petrochenkov]

would you like 2 separate prs?

Let's not complicate things and just merge.
@bors r+

[rust-bors]

📌 Commit 72e9ddc has been approved by petrochenkov

It is now in the queue for this repository.