semicolon_in_expressions_from_macros: Lint on non-local macros too by joshtriplett · Pull Request #159222 · rust-lang/rust

joshtriplett · 2026-07-13T12:47:17Z

The semicolon_in_expressions_from_macros lint previously suppressed
warnings about non-local macros. This masks a lint that will
subsequently become a hard error.

Stop suppressing it, dropping the is_local flag and check.

Fix the test for this case to now expect the error. Drop a separate test
that depended on the lack of error (and that specifically notes it
should be dropped once the lint becomes a hard error).

The `semicolon_in_expressions_from_macros` lint previously suppressed warnings about non-local macros. This masks a lint that will subsequently become a hard error. Stop suppressing it, dropping the `is_local` flag and check. Fix the test for this case to now expect the error. Drop a separate test that depended on the lack of error (and that specifically notes it should be dropped once the lint becomes a hard error).

rustbot · 2026-07-13T12:47:22Z

r? @hanna-kruppe

rustbot has assigned @hanna-kruppe.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 18 candidates

petrochenkov · 2026-07-13T12:52:17Z

@bors r+

rust-bors · 2026-07-13T12:52:19Z

📌 Commit 9192337 has been approved by petrochenkov

It is now in the queue for this repository.

Urgau · 2026-07-13T13:29:30Z

Probably deserves to be on the releases notes.

@rustbot label +relnotes

semicolon_in_expressions_from_macros: Lint on non-local macros too The `semicolon_in_expressions_from_macros` lint previously suppressed warnings about non-local macros. This masks a lint that will subsequently become a hard error. Stop suppressing it, dropping the `is_local` flag and check. Fix the test for this case to now expect the error. Drop a separate test that depended on the lack of error (and that specifically notes it should be dropped once the lint becomes a hard error).

…uwer Rollup of 13 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #156712 (Pointer authentication config and user facing options) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #156609 (Consider structurally impossible Sized predicates in MIR) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

semicolon_in_expressions_from_macros: Lint on non-local macros too The `semicolon_in_expressions_from_macros` lint previously suppressed warnings about non-local macros. This masks a lint that will subsequently become a hard error. Stop suppressing it, dropping the `is_local` flag and check. Fix the test for this case to now expect the error. Drop a separate test that depended on the lack of error (and that specifically notes it should be dropped once the lint becomes a hard error).

…uwer Rollup of 14 pull requests Successful merges: - #159039 (resolve: fix effective visibilities for items in ambiguous glob sets) - #157706 (Deny `todo!()` in tidy) - #158535 (Support `#[track_caller]` on EII declarations) - #158632 (First steps of late-bound turbofishing (place FnDef behind a dummy binder)) - #158846 (Fix unused variable warnings for diverging expressions) - #159002 (Small refactorings in `need_type_info` module) - #159202 (Bump rustc-demangle to 0.1.28) - #159216 (Avoid using probe self_ty for delegation arguments) - #159222 (semicolon_in_expressions_from_macros: Lint on non-local macros too) - #156609 (Consider structurally impossible Sized predicates in MIR) - #157993 (Expose more info about ADTs and functions in rustc_public) - #158854 (Add `#[rustc_test_entrypoint_marker]`) - #158998 (Some minor ast validation and visiting cleanups) - #159123 (doc: clarify attr parser APIs)

JonathanBrouwer · 2026-07-13T17:00:11Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: https://productionresultssa7.blob.core.windows.net/actions-results/06bc32af-c7d1-4940-bb81-ba98a65b020e/workflow-job-run-f35fa0ed-923a-5c7b-a71c-de67c7fa0923/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-07-13T17%3A07%3A00Z&sig=qiTACPaqBZaMDYmvTfkJk2YnjYEJqnMZJdAxBdQkcSc%3D&ske=2026-07-13T19%3A40%3A18Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-07-13T15%3A40%3A18Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-07-13T16%3A56%3A55Z&sv=2025-11-05

rust-bors · 2026-07-13T17:00:20Z

This pull request was unapproved.

This PR was contained in a rollup (#159236), which was unapproved.

View changes since this unapproval

joshtriplett · 2026-07-13T21:18:25Z

I wasn't expecting this to get r+ed and get pulled into rollups before it passed CI. I'll work on fixing the failures.

The macro is used in expressions, but the arm for eliminating a trailing comma introduces a semicolon.

rustbot · 2026-07-13T22:02:30Z

Some changes occurred in std_detect

cc @Amanieu, @folkertdev, @sayantn

joshtriplett · 2026-07-13T22:02:44Z

@bors try

semicolon_in_expressions_from_macros: Lint on non-local macros too

Mark-Simulacrum · 2026-07-13T22:59:51Z

The default try runs a mostly normal x86_64-linux build so it's probably not super useful. I'd suggest dist-various-*; you can see a sample in the failing rollup (e.g., @bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-*).

joshtriplett · 2026-07-13T23:10:33Z

@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-*

semicolon_in_expressions_from_macros: Lint on non-local macros too try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*

rust-log-analyzer · 2026-07-14T00:10:54Z

The job test-various failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [debuginfo-gdb] tests/debuginfo/zst-interferes-with-prologue.rs ... ok

failures:

---- [debuginfo-gdb] tests/debuginfo/function-call.rs stdout ----
NOTE: compiletest thinks it is using GDB version 12001000
------gdb stdout------------------------------
GNU gdb (Ubuntu 12.1-0ubuntu1~22.04.2) 12.1
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word".
Breakpoint 1 at 0x9552: file /checkout/tests/debuginfo/function-call.rs, line 36.

Breakpoint 1, function_call::main () at /checkout/tests/debuginfo/function-call.rs:36
36     zzz(); // #break

------gdb stderr------------------------------
/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/function-call.gdb/function-call.debugger.script:11: Error in sourced command file:
Couldn't write extended state status: Bad address.

------------------------------------------

error: gdb failed to execute
status: exit status: 1
command: PYTHONPATH="/checkout/src/etc" "/usr/bin/gdb" "-quiet" "-batch" "-nx" "-command=/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/function-call.gdb/function-call.debugger.script"
--- stdout -------------------------------
GNU gdb (Ubuntu 12.1-0ubuntu1~22.04.2) 12.1
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word".
Breakpoint 1 at 0x9552: file /checkout/tests/debuginfo/function-call.rs, line 36.

Breakpoint 1, function_call::main () at /checkout/tests/debuginfo/function-call.rs:36
36     zzz(); // #break
------------------------------------------
--- stderr -------------------------------
/checkout/obj/build/x86_64-unknown-linux-gnu/test/debuginfo/function-call.gdb/function-call.debugger.script:11: Error in sourced command file:
Couldn't write extended state status: Bad address.
------------------------------------------

rust-bors · 2026-07-14T02:28:50Z

💔 Test for 6ade460 failed: CI. Failed job:

try - test-various (web logs, enhanced plaintext logs)

joshtriplett · 2026-07-14T22:57:04Z

Looks potentially spurious.

@bors try jobs=test-various

semicolon_in_expressions_from_macros: Lint on non-local macros too try-job: test-various

rust-bors · 2026-07-15T00:55:44Z

☀️ Try build successful (CI)
Build commit: 2b850d5 (2b850d5dbbf142fe9af6c1cf3347eee31bb3bf63)
Base parent: da80ed0 (da80ed0708a09dc096c184345d6eb42cbcd50a1e)

joshtriplett · 2026-07-15T03:47:09Z

@rustbot ready

petrochenkov · 2026-07-15T10:26:58Z

@bors r+

rust-bors · 2026-07-15T10:27:01Z

📌 Commit aa53fee has been approved by petrochenkov

It is now in the queue for this repository.

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2026

rustbot assigned hanna-kruppe Jul 13, 2026

joshtriplett assigned petrochenkov and unassigned hanna-kruppe Jul 13, 2026

joshtriplett mentioned this pull request Jul 13, 2026

Make semicolon_in_expressions_from_macros a hard error #159218

Open

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2026

rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 13, 2026

rustbot mentioned this pull request Jul 13, 2026

Tracking issue for release notes of #159222: semicolon_in_expressions_from_macros: Lint on non-local macros too #159223

Open

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 13 pull requests #159231

Closed

JonathanBrouwer mentioned this pull request Jul 13, 2026

Rollup of 14 pull requests #159236

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2026

std_detect: Eliminate incorrect symlink in macro arm

aa53fee

The macro is used in expressions, but the arm for eliminating a trailing comma introduces a semicolon.

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 13, 2026

Auto merge of #159222 - joshtriplett:main, r=<try>

056811a

semicolon_in_expressions_from_macros: Lint on non-local macros too

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 14, 2026

Auto merge of #159222 - joshtriplett:main, r=<try>

2b850d5

semicolon_in_expressions_from_macros: Lint on non-local macros too try-job: test-various

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026

Uh oh!

Uh oh!

Conversation

joshtriplett commented Jul 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 13, 2026

Uh oh!

petrochenkov commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 13, 2026

Uh oh!

Urgau commented Jul 13, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Jul 13, 2026

Uh oh!

rust-bors Bot commented Jul 13, 2026

Uh oh!

joshtriplett commented Jul 13, 2026

Uh oh!

rustbot commented Jul 13, 2026

Uh oh!

joshtriplett commented Jul 13, 2026

Uh oh!

This comment has been minimized.

Mark-Simulacrum commented Jul 13, 2026

Uh oh!

joshtriplett commented Jul 13, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jul 14, 2026

Uh oh!

rust-bors Bot commented Jul 14, 2026

Uh oh!

joshtriplett commented Jul 14, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 15, 2026

Uh oh!

joshtriplett commented Jul 15, 2026

Uh oh!

petrochenkov commented Jul 15, 2026

Uh oh!

rust-bors Bot commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

joshtriplett commented Jul 13, 2026 •

edited by rustbot

Loading