Reject unknown rust-toolchain.toml keys#4956
Closed
Bortlesboat wants to merge 1 commit into
Closed
Conversation
Contributor
|
There already was a PR for this before you claimed it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject unknown keys at both levels of
rust-toolchain.tomldeserialization.This prevents misspellings such as
channnel = "nightly"from being silently ignored and also rejects unsupported top-level sections. The TOML parser reports the unknown key and lists the supported fields, while valid and legacy toolchain files retain their existing behavior.Fixes #2876.
Validation:
[toolchain]key and an unknown top-level sectionconfig::testsparser tests pass with thetestfeaturecargo clippy --all-targets --features test -- -D warningscargo fmt --all -- --checkgit diff --checkI also attempted the broader
--all-featuresClippy command. On this Windows host its optional vendored-OpenSSL lane requires aperlexecutable and stopped while configuring OpenSSL; the repository's normal Windows feature set above is green.