ci(dist): ensure pushing to dev-static on stable update#4958
Open
rami3l wants to merge 1 commit into
Open
Conversation
| aws-region: us-east-1 | ||
| - name: Deploy build to rustup-builds bucket for release team | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' && matrix.mode == 'release' | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/stable' && matrix.mode == 'release' |
Member
There was a problem hiding this comment.
I think we want the condition here to be an OR. You can see how Rust's CI does this here: https://github.com/rust-lang/rust/blob/5503df87342a73d0c29126a7e08dc9c1255c46ad/.github/workflows/ci.yml#L82 -- note that all branches with approved commits upload.
The goal is that we have artifacts for every merged PR, which means that we can build e.g. a dev-static nightly at any time, bisect, etc. I think I'd want to achieve the same shape for rustup.
Member
Author
There was a problem hiding this comment.
@Mark-Simulacrum Thanks for the review! I think this predicate already exists in previous steps so I've copied it over.
rami3l
force-pushed
the
dist/cd-dev-static-on-stable
branch
6 times, most recently
from
9c36b65 to
c4fa331
Compare
rami3l
force-pushed
the
dist/cd-dev-static-on-stable
branch
from
c4fa331 to
d2de939
Compare
djc
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4738.
During our release process, @Mark-Simulacrum wasn't able to find the required
dev-staticartifacts from the commit 69d7545 which is probably caused by our new release process disengagingstablefrommain.This looks like a pre-existing bug, since the branch used for artifact uploading is semantically incorrect. However, this issue was unfortunately never exposed before since it used to be that
stablewas trackingmain, thus with everystablewe would want to release, the artifacts have been uploaded by a previous CI step onmain.This fix ensures that the
dev-staticuploads happen whenstableis updatedinstead ofin addition tomain.