Merge stdarch-gen-hexagon-scalar into stdarch-gen-hexagon#2175
Open
xonx4l wants to merge 1 commit into
Open
Conversation
xonx4l
force-pushed
the
merge-hexagon-generators
branch
from
1012847 to
bcb8a41
Compare
folkertdev
reviewed
Jun 27, 2026
Contributor
There was a problem hiding this comment.
This file move is kind of tough to review, are there any noteworthy changes here?
Contributor
Author
There was a problem hiding this comment.
Only Two changes -:
- In imports dropped
run_generatorandModekeptGENERATED_MARKER. - The old
fn main()is replaced by a smallpub fn generate()that just does the header read, parse, and writes v64.rs / v128.rs. Everything in betweenparse_header,intrinsic model,generate_module_fileetc.is identical to the prior file.
Comment on lines
-1698
to
-1699
| // Either "check" to check the output versus the committed output, or "bless" | ||
| // to update the output. |
Contributor
There was a problem hiding this comment.
I'd like to keep the comment.
| println!(" Output: {}", hexagon_dir.join(filename).display()); | ||
| } | ||
| scalar::generate(&crate_dir, out_dir)?; | ||
| hvx::generate(&crate_dir, out_dir)?; |
Contributor
There was a problem hiding this comment.
maybe also comment here what files we expect these to create/update?
xonx4l
commented
Jun 28, 2026
| } | ||
|
|
||
| /// Parse the HVX header in `crate_dir` and write `v64.rs` and `v128.rs` into `out_dir`. | ||
| pub fn generate(crate_dir: &std::path::Path, out_dir: &std::path::Path) -> Result<(), String> { |
Contributor
Author
There was a problem hiding this comment.
The major change to review in this file .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges stdarch-gen-hexagon-scalar into stdarch-gen-hexagon .
Merges
stdarch-gen-hexagon-scalarintostdarch-gen-hexagonas newscalarmodule so a single binary produces every file undercore_arch/src/hexagon/in one bless run.So
main.rsis now a tiny orchestrator that callsscalar::generatethenhvx::generateinside onerun_generatorcall. Alsoscalar.rsnow also writesGENERATED_MARKERso the harness sees it as owned.r? @folkertdev