Skip to content

Fix crash caused by teleporting using Iron's Teleport scroll#700

Open
gjorgdy wants to merge 2 commits into
ryanhcode:mainfrom
gjorgdy:main
Open

Fix crash caused by teleporting using Iron's Teleport scroll#700
gjorgdy wants to merge 2 commits into
ryanhcode:mainfrom
gjorgdy:main

Conversation

@gjorgdy

@gjorgdy gjorgdy commented May 2, 2026

Copy link
Copy Markdown

The mixin for player teleportation did not cover all possible teleport methods the class contains. One of these methods which was not covered is called by Iron's Spells and Spellbooks to teleport using the teleport and the portal spells.

A small other issue still persists, portal frames only being to teleport players to sublevels, but not detecting player collision when the frame is in a sublevel. I am not quite sure if this is an issue caused by Iron's or by Sable at this moment.

Closes #496

@CLAassistant

CLAassistant commented May 2, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Variapolis

Variapolis commented May 20, 2026

Copy link
Copy Markdown

Is there a reason why your PR is for main rather than your feature/irons-compat branch? In my brief testing I was able to teleport without issue using a build based off of that branch, including with portal frames. It seems that it is a better fix for this issue.

I'm planning on testing it on a server with around 8 players over the next few days and would be happy to report any feedback if it is wanted.

@gjorgdy

gjorgdy commented May 21, 2026

Copy link
Copy Markdown
Author

I initially also made another PR with that "irons-compat" branch, but the Sable devs said they would prefer to not have to maintain support for Irons and that it should be fixed on that mod itself.

This PR is a generic fix to teleportation and should also fix other mods without requiring to add implicit compatibility.

@Variapolis

Copy link
Copy Markdown

I'm seeing another issue here where the teleport using portal frames fails if the sublevel is too far way in an unloaded chunk. Is this possible to fix?

@gjorgdy

gjorgdy commented May 23, 2026

Copy link
Copy Markdown
Author

I have looked into it, but Sable does not seem to have a simple tool to calculate the relative position of an unloaded sublevel.

There have been other people who have gotten it to work tho, like WaystonesSable.

Preferably this should be added to the utility functions in Sable Companion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Teleportation onto physics objects is broken

4 participants