Add necessary arguments to JNI call to allow destructive block callbacks#830
Closed
cakeGit wants to merge 13 commits into
Closed
Add necessary arguments to JNI call to allow destructive block callbacks#830cakeGit wants to merge 13 commits into
cakeGit wants to merge 13 commits into
Conversation
|
|
…lassBlockMixin.java
…ructiveBlockCallback.java
Owner
|
can we tag the overloads for backwards compatibility as deprecated? |
Owner
|
!! |
ryanhcode
approved these changes
May 21, 2026
ryanhcode
requested changes
May 21, 2026
ryanhcode
left a comment
ryanhcode
left a comment
Owner
There was a problem hiding this comment.
please remove the sable_rapier_binaries.zip.l4z change from this PR
Owner
|
this shouldn't be necessary after 9736e55, let me know if more changes are needed |
Contributor
Author
|
Nope that's perfect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On draft due to
Caused by: java.lang.RuntimeException: Rapier native panic: Internal error: island should be awake.issues which apparently are elsewhere, this just really seems to cause it.