Fix permission#232
Conversation
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
📝 WalkthroughWalkthroughThis PR updates container image versions to 0.10.3 across build workflows and Dockerfiles, reconfigures the EOL-checker image with a new working directory and adds the nss_wrapper package, and simplifies logger output by removing file handler setup. ChangesContainer versioning and logger refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 62.56% 62.42% -0.14%
==========================================
Files 13 13
Lines 1349 1344 -5
==========================================
- Hits 844 839 -5
Misses 505 505
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile.eol-checker`:
- Around line 5-10: Remove the duplicate HOME variable definition (the two
identical HOME=" /home/eol-checker" entries) and ensure WORK_DIR matches the
actual image working path; update WORK_DIR to the correct directory used by the
image (e.g., set WORK_DIR="/home/eol-checker" to align with HOME and
NAME="eol-checker", or change to "/root/ci-scripts" if the code lives in
/root/ci-scripts), keeping SUMMARY and DESCRIPTION unchanged; modify the ENV
block containing HOME, SUMMARY, DESCRIPTION, NAME and WORK_DIR so it has a
single HOME entry and a WORK_DIR that exists in the base image.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 990c56c4-a71a-4913-93fe-837467397eb8
📒 Files selected for processing (5)
.github/workflows/build-and-push.ymlDockerfile.daily-testsDockerfile.eol-checkerMakefileeol-checker/eol_checker/custom_logger.py
💤 Files with no reviewable changes (1)
- eol-checker/eol_checker/custom_logger.py
Summary by CodeRabbit
0.10.3for daily-tests and eol-checker