Skip to content

Fix permission#232

Merged
phracek merged 2 commits into
sclorg:masterfrom
phracek:fix_permission
May 29, 2026
Merged

Fix permission#232
phracek merged 2 commits into
sclorg:masterfrom
phracek:fix_permission

Conversation

@phracek
Copy link
Copy Markdown
Member

@phracek phracek commented May 29, 2026

Summary by CodeRabbit

  • Chores
    • Updated container image versions to 0.10.3 for daily-tests and eol-checker
    • Modified eol-checker image working directory configuration
    • Added nss_wrapper package to eol-checker image dependencies
    • Simplified logging handler initialization

Review Change Stack

phracek added 2 commits May 29, 2026 09:46
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

📝 Walkthrough

Walkthrough

This PR updates container image versions to 0.10.3 across build workflows and Dockerfiles, reconfigures the EOL-checker image with a new working directory and adds the nss_wrapper package, and simplifies logger output by removing file handler setup.

Changes

Container versioning and logger refactor

Layer / File(s) Summary
Container image version consistency
.github/workflows/build-and-push.yml, Dockerfile.daily-tests, Dockerfile.eol-checker, Makefile
Version tags for upstream-daily-tests and upstream-eol-checker images are bumped to 0.10.3 across GitHub Actions workflow publish configuration, Dockerfile RELEASE_UPSTREAM environment variables, and Makefile build targets.
EOL-checker image runtime configuration
Dockerfile.eol-checker
Working directory WORK_DIR is changed from /home/eol-checker/... to /home/nightly/ci-scripts, and nss_wrapper package is added to the dnf install command.
Console-only logger setup
eol-checker/eol_checker/custom_logger.py
The setup_logger function registers the console handler earlier in the initialization sequence and removes the previous file-handler setup code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • sclorg/ci-scripts#226: Both PRs update the upstream-daily-tests image versioning across .github/workflows/build-and-push.yml, Dockerfile.daily-tests, and Makefile.
  • sclorg/ci-scripts#225: Both PRs bump the upstream-daily-tests version tag in build and workflow configuration files.
  • sclorg/ci-scripts#231: Both PRs update Dockerfile.eol-checker image configuration and eol-checker logging setup.

Suggested labels

ready for review

Poem

🐰 Version bumps hop across the files,
Container tags all aligned with smiles,
EOL-checker finds a newer nest,
Logging now flows console-blessed!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix permission' is vague and generic, lacking specificity about which permissions are being fixed and in what context. Revise the title to be more descriptive, such as 'Fix logging permissions and remove file handler' or 'Update container versions and fix logger permission setup'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.42%. Comparing base (4547ca0) to head (879e8c9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   62.56%   62.42%   -0.14%     
==========================================
  Files          13       13              
  Lines        1349     1344       -5     
==========================================
- Hits          844      839       -5     
  Misses        505      505              
Flag Coverage Δ
daily-tests-unit 44.26% <ø> (ø)
eol-checker-unit 97.33% <ø> (-0.04%) ⬇️
ocp-stream-generator-unit 84.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
eol-checker/eol_checker/custom_logger.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Dockerfile.eol-checker`:
- Around line 5-10: Remove the duplicate HOME variable definition (the two
identical HOME=" /home/eol-checker" entries) and ensure WORK_DIR matches the
actual image working path; update WORK_DIR to the correct directory used by the
image (e.g., set WORK_DIR="/home/eol-checker" to align with HOME and
NAME="eol-checker", or change to "/root/ci-scripts" if the code lives in
/root/ci-scripts), keeping SUMMARY and DESCRIPTION unchanged; modify the ENV
block containing HOME, SUMMARY, DESCRIPTION, NAME and WORK_DIR so it has a
single HOME entry and a WORK_DIR that exists in the base image.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 990c56c4-a71a-4913-93fe-837467397eb8

📥 Commits

Reviewing files that changed from the base of the PR and between 4547ca0 and 879e8c9.

📒 Files selected for processing (5)
  • .github/workflows/build-and-push.yml
  • Dockerfile.daily-tests
  • Dockerfile.eol-checker
  • Makefile
  • eol-checker/eol_checker/custom_logger.py
💤 Files with no reviewable changes (1)
  • eol-checker/eol_checker/custom_logger.py

Comment thread Dockerfile.eol-checker
@phracek phracek merged commit 577424e into sclorg:master May 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant