feat: pp.scale allow selecting correction#4220
Open
AxelMcKenna wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4220 +/- ##
=======================================
Coverage 79.92% 79.93%
=======================================
Files 121 121
Lines 12958 12958
=======================================
+ Hits 10357 10358 +1
+ Misses 2601 2600 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
Please change to the standard name, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4196.
This adds a selectable
correctionparameter tosc.pp.scale. The default remainscorrection=1, so existing behaviour is unchanged.The parameter is propagated through array, masked-array, sparse, and
AnnDatascaling paths. The documentation now explains how the variance divisor is calculated.correction=0andcorrection=1, covering dense, CSR, and CSC inputs; direct arrays andAnnData; masked and unmasked observations; and centered and non-centered scaling.