build: remove maven-javadoc-plugin skip in core-shaded

[nikagra]

Summary

Fixes core-shaded javadoc generation broken since deaeb1c ("build: drop Java 8 support", May 25 2026), which added <skip>true</skip> to the maven-javadoc-plugin in core-shaded/pom.xml to paper over a javadoc compilation failure introduced by the Netty 4.1.135.Final bump.

Problem

With <skip>true</skip> at the plugin level, no javadoc jar is attached for the core-shaded artifact during a release. Sonatype Central rejects the upload because javadoc jars are required for all published artifacts.

The underlying compilation failure was caused by two missing dependencies on the javadoc classpath when processing the shaded sources:

1. org.jetbrains:annotations — Netty 4.1.135.Final added @NotNull, @VisibleForTesting, and @Async.Execute/Schedule from this package.
2. ch.randelshofer:fastdoubleparser — Jackson 2.21.x sources reference this package, but it is bundled-and-shaded inside jackson-core with no standalone resolvable Maven coordinate.

Changes

• Remove the <skip>true</skip> global plugin configuration.
• Add org.jetbrains:annotations:23.0.0 to additionalDependencies in the attach-javadocs execution (same version Netty uses as a provided dependency).
• Add <failOnError>false</failOnError> to the attach-javadocs execution to tolerate the unresolvable fastdoubleparser references. Those sources are already excluded from the javadoc output via excludePackageNames, so the jar still contains the full public API documentation.

Test plan

• Trigger a release build and confirm the core-shaded javadoc jar is generated and accepted by Sonatype Central.

[coderabbitai]

📝 Walkthrough

Walkthrough

The maven-javadoc-plugin configuration in core-shaded/pom.xml previously contained <skip>true</skip>, which disabled all javadoc generation and attachment for that module. This change removes those three lines, causing the plugin to run its configured executions during the build instead of being skipped.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main build change in core-shaded.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The description directly matches the change: removing the javadoc skip from core-shaded pom.xml to restore javadoc jar generation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}