fix: _set_keyspace_for_all_pools passes only the last pool's errors to callback#915
Open
mykaul wants to merge 3 commits into
Open
fix: _set_keyspace_for_all_pools passes only the last pool's errors to callback#915mykaul wants to merge 3 commits into
mykaul wants to merge 3 commits into
Conversation
…o callback The pool_finished_setting_keyspace closure was calling callback(host_errors) instead of callback(errors), so when the last pool to finish had no errors, the callback received an empty list instead of the accumulated error dict from all pools. This caused _set_keyspace_completed to report success (not [] is True) even when other pools had failures — keyspace changes silently succeeded with partial failures dropped. Introduced in d281b50 (2013-10-11). Fixes #914
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (57)
💤 Files with no reviewable changes (26)
📝 WalkthroughWalkthrough
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| from cassandra.segment import SegmentCodec, CrcException | ||
| from cassandra.util import OrderedDict | ||
| from cassandra.shard_info import ShardingInfo | ||
| from cassandra.shard_info import ShardingInfo # noqa: F401 # re-exported for cassandra.connection.ShardingInfo |
Comment on lines
+33
to
+40
| from cassandra.cqltypes import (AsciiType, BytesType, BooleanType, # noqa: F401 | ||
| CounterColumnType, DateType, DecimalType, # noqa: F401 | ||
| DoubleType, FloatType, Int32Type, # noqa: F401 | ||
| InetAddressType, IntegerType, ListType, # noqa: F401 | ||
| LongType, MapType, SetType, TimeUUIDType, # noqa: F401 | ||
| UTF8Type, VarcharType, UUIDType, UserType, # noqa: F401 | ||
| TupleType, lookup_casstype, SimpleDateType, # noqa: F401 | ||
| TimeType, ByteType, ShortType, DurationType) # noqa: F401 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #914
pool_finished_setting_keyspacewas callingcallback(host_errors)(the last pool to finish) instead ofcallback(errors)(all accumulated errors).This caused keyspace changes to silently report success when the last pool finished without errors, even if other pools had failures.
Introduced in
d281b50c9(2013-10-11).