Follow-up: Added CoAP socket #4334#5000
Closed
polybassa wants to merge 19 commits into
Closed
Conversation
Fixing response payload Some docstring and bug fixes. Finished CoAP server logic implementation Added client interaction Client/Server done. Added delayed response handling Fixing small problems Unit tests Documentation
- Moved the defines/enumerators to coap.py - Changed the send() function to match the SuperSocket declaration - Updated unit tests
- Implemented coap.answers function - Fixed some types - Remove unnecessary override - Changed sr and sr1 functions signatures.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Changed return type hint for `__enter__` method to `Self`. - Updated imports to include `Self` from `scapy.compat`. Remove `setup.py` in favor of `pyproject.toml` configuration - Deleted `setup.py` as its functionality is now handled by `pyproject.toml`. - Updated `pyproject.toml` to explicitly include `readme`. Reorganize imports and improve code formatting in `scapy/sendrecv.py` - Optimized import order for better readability. - Adjusted code indentation and removed unnecessary blank lines for consistency. - Updated `pyproject.toml` to include `readme` as a dynamic attribute. Add `setup.py` and reorganize imports in `scapy/sendrecv.py` - Introduced `setup.py` for setuptools support. - Refactored and reordered imports in `scapy/sendrecv.py` to improve readability and maintainability. - Minor improvements and consistency changes to `scapy/sendrecv.py`. Handle missing edge keys gracefully in graph component Fix hashret of DoIP Add version field for DoIP and DoIP sockets Update .gitlab-ci.yml file fix Build Disable open LDAP Dissecto DIFFs update documentation use python scm way to generate versions fix spellcheck testing new versioning Fix the newest codespell update (secdev#4400) fix spellcheck Disable debug message fix flake Remove log message remove diffs between github and dissecto
fixes improve thread safety by replacing instance lock with class-level lock tracking add return type annotation to `__del__` method in graph module replace instance lock initialization with defaultdict for thread safety
…nd metadata (secdev#4919)" This reverts commit 2e7c97f.
… packet metadata during serialization The new regression tests protect against breaking older pickle payloads by ensuring legacy tuple-state unpickling still works. They also lock in current behavior for the new state format by checking full metadata and comments fidelity after pickle roundtrip. This gives coverage for both backward compatibility and current serialization behavior in one place: test/regression.uts.
AI-Assisted: yes (GitHub CoPilot Auto)
Closed
Contributor
Author
|
@gpotter2 How should I proceed with the trailer check for "old" commits? |
Contributor
Author
|
this branch has a dirty history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a CoAP socket, pretty similar on how ISOTPSoftSocket works.
I implemented the basic message exchange, mostly based on the RFC-7252.
Known-limitations
General comments
It has a dependency for
from scapy.contrib.isotp.isotp_soft_socket import TimeoutScheduler, I found nice how this is implemented, so I just used it, I didn't want to copy/paste again.Also I added some unit tests for the basic cases.
Quick usage
This follow-up reintegrates master and adds additional unit tests