Remove redundant snake computations#30
Open
ninioArtillero wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation (of
dstep) deviates from the paper in that it extends each candidate along the available snake before comparing matching candidates.This PR contains a refactoring that computes the extension along the snakes after matching candidates have been merged, thus voiding the computation of a significant amount of redundant snakes. Indeed, given that
addsnakepreserves a node's diagonal (as proved in #29), both candidates are know to be on the same diagonal before extending them, so we necessarily get the same result.The change gives an improvent of ~40% reduction of
cabal benchtime (almost twice as fast), andcabal testpasses.